Verify result figures using approval testing #890
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move Namer to own module. Approval files are now stored in `/tests/approvals` instead of `/tests/integrationtests/approved`.
Previously tests checked only if result description is not None or contained a sub-string. Now the whole result description is verified using approval testing.
matthiasschaub
changed the title
to be able to output plotly figures as png which is needed to use approval testsing on figures.
matthiasschaub
force-pushed
the
approval-tests-for-figures
branch
from
09f7d54 to
6671a35
Compare
matthiasschaub
force-pushed
the
approval-tests-for-figures
branch
2 times, most recently
from
af04271 to
4154b9d
Compare
add custom PlotlyReporter for approvaltests to verify the image representation of Plotly figures using diff tools which can display images (E.g. pycharm and vscode)
Use ImageReporter to verify result figures by displaying an received and approved images of the figure in a diff tool
matthiasschaub
force-pushed
the
approval-tests-for-figures
branch
from
4154b9d to
94bb7ca
Compare
matthiasschaub
force-pushed
the
approval-tests-for-figures
branch
5 times, most recently
from
162ae09 to
0adeed7
Compare
Currentness indicator does format time to string representation which where different depending on the locale setting of the machine. This commit will set the locale to always be en_US.
for mapping saturation indicator
matthiasschaub
force-pushed
the
approval-tests-for-figures
branch
from
0adeed7 to
a075b2e
Compare
matthiasschaub
force-pushed
the
approval-tests-for-figures
branch
from
6b94fe7 to
d50d968
Compare
if PlotlyFigureReport fails
matthiasschaub
force-pushed
the
approval-tests-for-figures
branch
from
f1c310b to
5281bc1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Corresponding issue
Closes #889
New or changed dependencies
Todos
[ ] Support Windows by adding PyCharm and Visual Studio Code reporter (Winows paths)-> Fallback to PythonNativeReporter (print to console)Checklist
main(e.g. throughgit rebase mainif necessary)