-
Notifications
You must be signed in to change notification settings - Fork 0
[29] use reusable workflow for testing #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## deploy-test #31 +/- ##
=============================================
Coverage 100.00% 100.00%
=============================================
Files 5 6 +1
Lines 152 234 +82
Branches 7 11 +4
=============================================
+ Hits 152 234 +82
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
update nzshm-model to the released version
pyproject.toml
Outdated
@@ -9,7 +9,7 @@ packages = [{include = "nshm_model_graphql_api"}] | |||
|
|||
[tool.poetry.dependencies] | |||
python = "^3.10" | |||
nzshm-model = {git = "https://github.com/GNS-Science/nzshm-model", rev = "pre-release"} | |||
nzshm-model = {git = "https://github.com/GNS-Science/nzshm-model", rev = "pre-release-0.13.5"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is a 0.13.6 released and published on pypi we can use
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tried that out and created #32 to upgrade to nzshm-model 0.13.6
(there's a breaking change in the library). For some reason, pre-release-0.13.5
also no longer works to build this (strangely, it looks like it never should have worked). I've now fixed the version at 0.10.6
which is the last version before a breaking change in nzshm-model
(see #32).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @voj
closes #29
Note that I needed to change the
nzshm-model
version as the old one no longer exists.