Skip to content

[29] use reusable workflow for testing #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 28, 2025
Merged

Conversation

voj
Copy link
Collaborator

@voj voj commented Apr 14, 2025

closes #29

Note that I needed to change the nzshm-model version as the old one no longer exists.

@voj voj self-assigned this Apr 14, 2025
Copy link

codecov bot commented Apr 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (6a5c629) to head (a28d62e).
Report is 7 commits behind head on deploy-test.

Additional details and impacted files
@@              Coverage Diff              @@
##           deploy-test       #31   +/-   ##
=============================================
  Coverage       100.00%   100.00%           
=============================================
  Files                5         6    +1     
  Lines              152       234   +82     
  Branches             7        11    +4     
=============================================
+ Hits               152       234   +82     
Flag Coverage Δ
unittests 100.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@voj voj requested review from chrisbc and chrisdicaprio April 14, 2025 04:43
@voj voj marked this pull request as ready for review April 14, 2025 04:43
Copy link
Collaborator

@chrisdicaprio chrisdicaprio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update nzshm-model to the released version

pyproject.toml Outdated
@@ -9,7 +9,7 @@ packages = [{include = "nshm_model_graphql_api"}]

[tool.poetry.dependencies]
python = "^3.10"
nzshm-model = {git = "https://github.com/GNS-Science/nzshm-model", rev = "pre-release"}
nzshm-model = {git = "https://github.com/GNS-Science/nzshm-model", rev = "pre-release-0.13.5"}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is a 0.13.6 released and published on pypi we can use

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tried that out and created #32 to upgrade to nzshm-model 0.13.6 (there's a breaking change in the library). For some reason, pre-release-0.13.5 also no longer works to build this (strangely, it looks like it never should have worked). I've now fixed the version at 0.10.6 which is the last version before a breaking change in nzshm-model (see #32).

@voj voj requested a review from chrisdicaprio April 27, 2025 23:40
Copy link
Collaborator

@chrisdicaprio chrisdicaprio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @voj

@voj voj merged commit e4fb8d9 into deploy-test Apr 28, 2025
3 checks passed
@voj voj deleted the 29-reusable-workflow branch May 6, 2025 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants