Skip to content

GPII-2046: Ensure that settings handlers always write to active profiles #477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
javihernandez wants to merge 2 commits into
base: master
Choose a base branch
from
Open

GPII-2046: Ensure that settings handlers always write to active profiles #477

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
96c7656
GPII-2046: Stop passing the GPII userToken to Orca's settings handler
javihernandez Oct 5, 2016
eef223a
GPII-2046: Updated Orca's portion in dynamic device reporter tests
javihernandez Oct 5, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions testData/solutions/linux.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -377,9 +377,6 @@
"settingsHandlers": {
"configuration": {
"type": "gpii.orca",
"options": {
"user": "${{userToken}}"
},
"capabilities": [
Copy link
Copy Markdown
Member

@amb26 amb26 Nov 22, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there no corresponding linux pull request to this? What does the settings handler do if the user token is not supplied?

Copy link
Copy Markdown
Member Author

@javihernandez javihernandez Nov 25, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, there's no linux side for this. As I mentioned back in the meeting we talked about this thing I removed this constraint in Orca settings handler during the last update but I forgot to remove the universal "bits" of it. I agree that this can be ready to go in as a separate pull request since we still need to make some accommodations in UNIVERSAL before the real issue (GPII-2046) can be addressed. Let me know if you want me to make a new JIRA/pr and get this merged ASAP.

"http://registry\\.gpii\\.net/common/screenReaderTTSEnabled"
],
Expand Down
9 changes: 0 additions & 9 deletions tests/platform/linux/linux-dynamicDeviceReporter-testSpec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,9 +44,6 @@ gpii.tests.deviceReporterAware.linux.orca.testDefs = [
},
"verbalizePunctuationStyle": 0,
"voices.default.average-pitch": 1.5
},
"options": {
"user": "screenreader_common"
}
}
]
Expand Down Expand Up @@ -86,9 +83,6 @@ gpii.tests.deviceReporterAware.linux.orca.testDefs = [
},
"verbalizePunctuationStyle": 0,
"voices.default.average-pitch": 1.5
},
"options": {
"user": "screenreader_orca"
}
}
]
Expand Down Expand Up @@ -127,9 +121,6 @@ gpii.tests.deviceReporterAware.linux.orca.testDefs = [
"name": "en-westindies"
},
"verbalizePunctuationStyle": 0
},
"options": {
"user": "screenreader_nvda"
}
}
]
Expand Down
9 changes: 0 additions & 9 deletions tests/platform/linux/linux-orca-testSpec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,9 +44,6 @@ gpii.tests.linux.orca.testDefs = [
},
"verbalizePunctuationStyle": 0,
"voices.default.average-pitch": 1.5
},
"options": {
"user": "screenreader_common"
}
}
]
Expand Down Expand Up @@ -80,9 +77,6 @@ gpii.tests.linux.orca.testDefs = [
},
"verbalizePunctuationStyle": 0,
"voices.default.average-pitch": 1.5
},
"options": {
"user": "screenreader_orca"
}
}
]
Expand Down Expand Up @@ -115,9 +109,6 @@ gpii.tests.linux.orca.testDefs = [
"name": "en-westindies"
},
"verbalizePunctuationStyle": 0
},
"options": {
"user": "screenreader_nvda"
}
}
]
Expand Down