Add build status badge to README.md#564
Open
amatas wants to merge 1 commit intoGPII:masterfrom
Open
Conversation
Contributor
|
Won't this show "build: failing" (or something similar) when a PR fails (since the universal-tests job is triggered only by PRs and not by commits to master)? That could indicate "master" is broken when it's a PR that's broken. Unless my understanding is wrong here. |
|
CI job passed: https://ci.gpii.net/job/universal-tests/591/ |
Contributor
Author
|
Nevermind, I've reverted the configuration of the Jenkins to only build the PRs due to the lack of options to only show the badges of the builds of the master branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The build of the master branch of Universal has been enabled. But Github doesn't have a place to show the build status of a particular branch, as the same way that it does in the PR conversation tab. This change adds a "badge" to the README.md with an image that indicates the status of the build of the master branch, in addition to a link to the log of the build.