Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PXBF-2086-fix-nested-date-criteria: check dates for child dependencies #2087

Merged
merged 1 commit into from
Jan 28, 2025
Merged

PXBF-2086-fix-nested-date-criteria: check dates for child dependencies #2087

merged 1 commit into from
Jan 28, 2025

Conversation

scottqueen-bixal
Copy link
Collaborator

@scottqueen-bixal scottqueen-bixal commented Jan 27, 2025 •
edited
Loading

PR Summary

adds functionality to include childDependency checking on Date fieldsets

Related Github Issue

Detailed Testing steps

  • point proxy to dev
  • navigate to first step
  • confirm child fieldsets are not visible
  • input date: >=18years
  • confirm child fieldsets are visible
  • adjust date: <18years
  • confirm child fieldsets are not visible
  • ensure you can complete form
  • ensure you can validate error alerts
  • ensure expected criteria still validates criteria correctly

expected:

Screen.Recording.2025-01-27.at.5.48.53.PM.mov

@scottqueen-bixal
Copy link
Collaborator Author

We tested this with a snapshot of the current dev database and noticed two issues that need to be addressed

#2089
#2088

despite these known regressions content has approved moving the working functionality in this PR as is.

@scottqueen-bixal scottqueen-bixal self-assigned this Jan 28, 2025
gchi25
gchi25 approved these changes Jan 28, 2025
View reviewed changes
Copy link
Contributor

@gchi25 gchi25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in local development site. Worked as expected.

@scottqueen-bixal scottqueen-bixal marked this pull request as ready for review January 28, 2025 16:22
@scottqueen-bixal scottqueen-bixal merged commit 4c4d138 into dev Jan 28, 2025
5 checks passed
@scottqueen-bixal scottqueen-bixal deleted the 2086-fix-nested-date-criteria branch January 28, 2025 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gchi25 gchi25 gchi25 approved these changes

Assignees

@scottqueen-bixal scottqueen-bixal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nested criteria not open as expected
2 participants
@scottqueen-bixal @gchi25