-
Notifications
You must be signed in to change notification settings - Fork 6
Add --include_path option to include external folders in Docker build context #182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
1dd07f5
Add --include_path (or -i) option to copy a folder into the build con…
mikaelsimard5 8aeeaea
Fix test_cli to use installed python version (3.9) rather than system…
mikaelsimard5 7563aa7
upgrade actions/setup-python as v2 may not be robust
mikaelsimard5 e9d4797
Add debug step to check Python version
mikaelsimard5 08ee6bd
Second debug step to verify python version before env clean
mikaelsimard5 9d2fa59
Moved clear runner space before installing python; otherwise it wipes…
mikaelsimard5 a621e79
fix mlflow==2.10.0 in test requirements to match csc-mlops requirements
mikaelsimard5 4549483
debugging step to understand why minio not working
mikaelsimard5 88eb617
adjusted deprecated command from createbuckets service and locked the…
mikaelsimard5 8954a94
Removed debugging step from test_cli
mikaelsimard5 faef3e7
Re-add createbuckets debug logging
mikaelsimard5 507f9da
Replace debug step with explicit wait for MLOps server readiness
mikaelsimard5 9ad30fe
Adjusting wait period
mikaelsimard5 d036d4b
ask minio if healthy before pursuing
mikaelsimard5 5aef93e
Wait for createbuckets to finish before running CLI test
mikaelsimard5 9860407
Wait for createbuckets using docker compose logs (blocks until contai…
mikaelsimard5 5931775
New theory - the issue is that createbucket was not waiting for minio…
mikaelsimard5 aca5575
robust settings for web
mikaelsimard5 65e7f97
Revert to last known working state
mikaelsimard5 832a76f
Restore robust MLOps server startup with proper depends_on conditions…
mikaelsimard5 a76a39e
removed redundant conditions in docker-compose
mikaelsimard5 e9ce063
removed --wait flag to understand why the test is now failing
mikaelsimard5 ca6e7f5
Clear runner space and add --wait to pull_request_tests
mikaelsimard5 c42301c
Moved include-path to experiment init; added robustness checks
mikaelsimard5 48bd4db
Renamed method to add paths so it doesn't conflict with the actual va…
mikaelsimard5 bccf904
Adjusted logic; if dest folder exists, then just point it out to user…
mikaelsimard5 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikewoodward94 marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikewoodward94 marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikewoodward94 marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| numpy | ||
| -f https://download.pytorch.org/whl/torch_stable.html | ||
| torch==2.0.1+cpu | ||
| mlflow | ||
| mlflow==2.10.0 | ||
| boto3 | ||
| requests==2.31.0 |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.