Skip to content

Conversation

@Jjiggu
Copy link
Collaborator

@Jjiggu Jjiggu commented Jun 16, 2025

작업 요약

Issue Link

문제점 및 어려움

해결 방안

Reference

Summary by CodeRabbit

  • 신규 기능

    • 매장 이름으로 검색할 수 있는 기능이 추가되었습니다.
  • 버그 수정

    • 매장 정보 생성 시 일부 필드의 기본값이 제대로 설정되지 않던 문제가 수정되었습니다. (isActive, deleted 필드 기본값 적용)
  • 기타

    • API 문서화 관련 주석이 제거되었습니다.

@coderabbitai
Copy link

coderabbitai bot commented Jun 16, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

이번 변경에서는 StoreController에서 Swagger/OpenAPI 어노테이션이 제거되었으며, 검색 엔드포인트 메서드의 위치가 조정되었습니다. Store 엔티티에는 Lombok의 @Builder.Default가 추가되어 빌더 사용 시 기본값이 보장됩니다. Store 검색 관련 메서드와 쿼리가 서비스, 레포지토리, 서비스 구현에 새롭게 추가되었습니다.

Changes

파일 경로 변경 요약
.../store/controller/StoreController.java Swagger/OpenAPI 어노테이션 제거, searchStores 메서드 위치 이동 및 어노테이션 제거
.../store/model/Store.java @Builder.Default 어노테이션을 isActive, deleted 필드에 추가하여 빌더 기본값 false 설정
.../store/repository/StoreRepository.java 이름 검색 및 삭제되지 않은 Store 조회용 쿼리 메서드 추가
.../store/service/StoreService.java 이름으로 Store를 검색하는 searchStoresByName 메서드 시그니처 추가
.../store/service/StoreServiceImpl.java 이름 검색 기능을 실제 구현하는 searchStoresByName 메서드 추가

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant StoreController
    participant StoreService
    participant StoreRepository
    participant StoreImageRepository

    Client->>StoreController: GET /stores/search?name={name}
    StoreController->>StoreService: searchStoresByName(name)
    StoreService->>StoreRepository: findByNameContainingIgnoreCaseAndDeletedFalse(name)
    StoreRepository-->>StoreService: List<Store>
    loop 각 Store에 대해
        StoreService->>StoreImageRepository: findByStoreId(store.id)
        StoreImageRepository-->>StoreService: List<StoreImage>
        StoreService->>StoreService: StoreReadDto로 매핑
    end
    StoreService-->>StoreController: List<StoreReadDto>
    StoreController-->>Client: ResponseEntity<List<StoreReadDto>>
Loading

Possibly related PRs

  • feat(store): store 검색 #27: StoreController의 searchStores 메서드, StoreService 및 StoreServiceImpl의 searchStoresByName, 그리고 레포지토리 쿼리 메서드 추가 등 동일한 검색 기능과 직접적으로 관련된 PR입니다.

Poem

🌱
새로운 검색이 피어났네,
Swagger 장식은 조용히 떠나고,
이름 속에 숨은 가게를 찾아
빌더는 기본값을 안고,
레포지토리는 부지런히 길을 내네.
오늘도 코드는 한 뼘 더 성장했어요!


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 276ee63 and bfbcd66.

📒 Files selected for processing (5)
  • src/main/java/com/example/gtable/store/controller/StoreController.java (2 hunks)
  • src/main/java/com/example/gtable/store/model/Store.java (2 hunks)
  • src/main/java/com/example/gtable/store/repository/StoreRepository.java (1 hunks)
  • src/main/java/com/example/gtable/store/service/StoreService.java (2 hunks)
  • src/main/java/com/example/gtable/store/service/StoreServiceImpl.java (2 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Jjiggu Jjiggu merged commit fc27894 into develop Jun 16, 2025
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants