-
Notifications
You must be signed in to change notification settings - Fork 0
refactor(config): cors 설정 추가 #52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The head ref may contain hidden characters: "feature/#51-\uC124\uC815\uBCC0\uACBD"
Conversation
Walkthrough이번 변경에서는 CORS 설정에 새로운 허용 origin이 추가되었으며, Security 설정 파일 내 문자열의 들여쓰기가 수정되었습니다. 기능적 로직 변화 없이 설정의 세부 포인트만 조정되었습니다. Changes
Poem
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/main/java/com/example/gtable/global/config/CorsConfig.java (1)
18-18: CORS 허용 Origin 추가 적용
http://localhost:5173가setAllowedOrigins에 잘 반영되었습니다.
원산지가 많아질 경우 유지보수를 위해setAllowedOriginPatterns로 패턴 기반 설정을 고려해보시는 것도 좋습니다.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
src/main/java/com/example/gtable/global/config/CorsConfig.java(1 hunks)src/main/java/com/example/gtable/global/config/SecurityConfig.java(1 hunks)
🔇 Additional comments (1)
src/main/java/com/example/gtable/global/config/SecurityConfig.java (1)
62-62: 들여쓰기 변경만 있으며 로직에는 영향 없습니다.
이 변경은 기능에 영향을 주지 않으므로 포맷팅 외에는 추가 조치가 필요하지 않습니다.
다만, 정의된CorsConfigurationSource빈이 실제로SecurityFilterChain에.cors()호출로 적용되고 있는지 한 번 확인 부탁드립니다.
작업 요약
Issue Link
문제점 및 어려움
해결 방안
Reference
Summary by CodeRabbit