merge to main

[hwangdae]

작업 내용

문제점 및 어려움

해결 방안

공유 사항

Summary by CodeRabbit

• New Features
  • Quantity selection now supports configurable min/max bounds (defaults applied).
  • Success messages support custom image size and button text.
• UI/Style
  • Footer buttons updated with gradient background in multiple pages.
  • Improved layouts: increased padding on Order Details, better text wrapping/spacing in Waiting pages, dynamic store notices, updated success image.
• Bug Fixes
  • Order creation flow: navigate and clear cart only on success; user alerted on failure.
  • Dates now display in Korea Standard Time with zero-padded time.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

Adds configurable min/max to QuantitySelector and applies bounds in WaitingPartySizeForm. Introduces optional width/height to SuccessMessagePage and updates WaitingSuccessPage (including asset swap). Adopts a background="gradient" prop in multiple PageFooterButton usages. Refines RemittanceWaitPage order flow. Adjusts various UI layouts. Updates formatDate to KST.

Changes

Cohort / File(s)	Summary of changes
Quantity bounds in QuantitySelector apps/nowait-user/src/components/common/QuantitySelector.tsx, apps/nowait-user/src/pages/waiting/waitingPartysize/WaitingPartySizeForm.tsx	QuantitySelector accepts optional min/max; computes defaults (1/99); uses dynamic boundary checks. WaitingPartySizeForm sets min=1, max=10.
Success message sizing and asset update apps/nowait-user/src/components/common/SuccessMessagePage.tsx, apps/nowait-user/src/pages/waiting/waitingSuccess/WaitingSuccessPage.tsx	SuccessMessagePage adds optional width/height (defaults 150px) and maps to img. WaitingSuccessPage switches image to waitingSuccess.png and passes width/height/buttonText.
Footer button background prop adoption apps/nowait-user/src/components/order/PageFooterButton.tsx, apps/nowait-user/src/pages/order/home/StorePage.tsx, apps/nowait-user/src/pages/order/orderList/OrderListPage.tsx, apps/nowait-user/src/pages/order/remittance/RemittancePage.tsx, apps/nowait-user/src/pages/waiting/storeDetail/StoreDetailPage.tsx	PageFooterButton signature supports optional background; usages updated to pass background="gradient".
Remittance wait flow adjustments apps/nowait-user/src/pages/order/remittenceWait/RemittanceWaitPage.tsx	Uses payer from location.state (string), computes totalPrice via sumTotalPrice, updates payload, logs response, on success stores depositorName, clears cart, navigates; on failure logs and alerts; removes unconditional navigation.
UI/layout and content tweaks apps/nowait-user/src/pages/order/orderDetails/OrderDetailsPage.tsx, apps/nowait-user/src/pages/waiting/WaitingSummary/WaitingSummaryPage.tsx, apps/nowait-user/src/pages/waiting/storeDetail/StoreDetailPage.tsx, apps/nowait-user/src/pages/waiting/storeNotice/StoreNoticePage.tsx	Adjusts padding (py-[64px]); swaps min-h-screen→min-h-dvh; reflows “부스” row and truncation; renders dynamic notice title/content; adds store log; updates notice header/text rendering.
Date formatting (KST) apps/nowait-user/src/utils/formatDate.ts	Formats using Korea Standard Time by offsetting UTC+9; zero-pads HH:mm; derives Y/M/D from KST Date.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor User
  participant Page as RemittanceWaitPage
  participant API as Order API
  participant Cart as Cart Store
  participant LS as localStorage
  participant Router

  User->>Page: Confirm remittance
  Page->>Cart: sumTotalPrice(items)
  Page->>API: createOrder({ depositorName, items, totalPrice })
  alt success
    API-->>Page: { success: true, ... }
    Page->>LS: setItem('depositorName', name)
    Page->>Cart: clearCart()
    Page->>Router: navigate(/{storeId}/order/success)
  else failure
    API-->>Page: { success: false | error }
    Page->>Page: console.error + alert()
  end

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~30 minutes

Possibly related PRs

• Develop 파일 main 병합 #227 — Also changes QuantitySelector prop interfaces and related typings; overlaps with this PR’s min/max additions.
• Develop #233 — Modifies QuantitySelector styling/sizing; related to the same component updated here.
• merge to main #337 — Touches RemittancePage logic around data fetching; related to files where this PR updates typing and PageFooterButton usage.

Suggested reviewers

• oriNuguri25

Poem

A nibble of code, a hop and a bound,
Min to max, the numbers are sound.
Buttons now shimmer with gradient delight,
KST clocks tick through the night.
Orders queue neatly—success, we zoom!
🐇✨ Shipping this patch with a gentle vroom.

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 0fd8e8f and 5807cd6.

⛔ Files ignored due to path filters (2)

• apps/nowait-user/src/assets/waitSuccess.png is excluded by !**/*.png
• apps/nowait-user/src/assets/waitingSuccess.png is excluded by !**/*.png

📒 Files selected for processing (13)

• apps/nowait-user/src/components/common/QuantitySelector.tsx (2 hunks)
• apps/nowait-user/src/components/common/SuccessMessagePage.tsx (3 hunks)
• apps/nowait-user/src/pages/order/home/StorePage.tsx (1 hunks)
• apps/nowait-user/src/pages/order/orderDetails/OrderDetailsPage.tsx (1 hunks)
• apps/nowait-user/src/pages/order/orderList/OrderListPage.tsx (1 hunks)
• apps/nowait-user/src/pages/order/remittance/RemittancePage.tsx (3 hunks)
• apps/nowait-user/src/pages/order/remittenceWait/RemittanceWaitPage.tsx (2 hunks)
• apps/nowait-user/src/pages/waiting/WaitingSummary/WaitingSummaryPage.tsx (3 hunks)
• apps/nowait-user/src/pages/waiting/storeDetail/StoreDetailPage.tsx (4 hunks)
• apps/nowait-user/src/pages/waiting/storeNotice/StoreNoticePage.tsx (1 hunks)
• apps/nowait-user/src/pages/waiting/waitingPartysize/WaitingPartySizeForm.tsx (1 hunks)
• apps/nowait-user/src/pages/waiting/waitingSuccess/WaitingSuccessPage.tsx (1 hunks)
• apps/nowait-user/src/utils/formatDate.ts (1 hunks)

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch develop

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

• Visit our Status Page to check the current availability of CodeRabbit.
• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.