feat: 맵 페이지 진입 포커스 처리, 주문 페이지 수정사항 반영 #424
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat:user notfound 페이지 수정
feat: 주문 페이지 수정사항 반영
feat: 페이지 진입 시 마커 중앙으로 포커스
feat: 송금 수단 없을 시 안보이게 처리
|
Caution Review failedThe pull request is closed. WalkthroughUpdates span UI text/styling tweaks, conditional rendering adjustments, a memoized export, a NotFound markup simplification, a StorePage effect scoping fix, and a substantial MapPage enhancement adding draggable panning and dynamic centering. Minor whitespace and asset usage changes are included. No public API changes except making one prop optional and memoizing one default export. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor U as User
participant SP as StorePage
participant Nav as Router
Note over SP: useEffect dependency triggers
SP->>SP: Check added
alt added is truthy
SP->>SP: showToast("...")
SP->>Nav: navigate(pathname, { replace: true })
else added is falsy
Note over SP: No navigation or toast
end
sequenceDiagram
autonumber
actor U as User
participant MP as MapPage
participant VP as Viewport
participant BM as Booths Data
MP->>BM: Compute booth bounds
MP->>VP: Measure viewport (width/height)
MP->>MP: Set initial positionX/positionY to center booths
U->>MP: Drag on map
MP->>MP: Update position with constraints (viewport-based)
U->>MP: Tap booth
alt Tap on booth (not a button)
MP->>MP: Set selectedBooth
MP->>U: Show details panel
else Tap on a button
Note over MP: Ignore close action
end
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. ⛔ Files ignored due to path filters (19)
📒 Files selected for processing (10)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 내용
문제점 및 어려움
해결 방안
공유 사항
Summary by CodeRabbit
New Features
Bug Fixes
Performance
Style
Accessibility