-
Notifications
You must be signed in to change notification settings - Fork 3
Develop #431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Develop #431
Conversation
fix: 토스트 알림 --> 주문상세 입금확인 클릭시 해당 알림 자동 삭제
feat: log monitoring 추가
|
Caution Review failedThe pull request is closed. WalkthroughAdds purgeNonWaiting to the new-order toast store to remove toasts for orders not in WAITING_FOR_PAYMENT. AdminOrders calls this on orders changes. User app’s Sentry init adds consoleLoggingIntegration to capture console logs. No other logic or signatures changed. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor Admin as Admin UI
participant AdminOrders as AdminOrders.tsx
participant ToastStore as useNewOrderToastStore
participant Toasts as Toast List
Admin->>AdminOrders: View orders page / refresh
AdminOrders->>AdminOrders: orders fetched/updated
AdminOrders->>ToastStore: purgeNonWaiting(orders)
ToastStore->>ToastStore: Compute waiting IDs (status == WAITING_FOR_PAYMENT)
alt toast.orderId not in waiting IDs
ToastStore->>Toasts: removeToast(toastId)
else
ToastStore->>Toasts: keep
end
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. 📒 Files selected for processing (3)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
작업 내용
문제점 및 어려움
해결 방안
공유 사항
Summary by CodeRabbit