Skip to content

Conversation

@oriNuguri25
Copy link
Collaborator

@oriNuguri25 oriNuguri25 commented Sep 2, 2025

작업 내용

문제점 및 어려움

해결 방안

공유 사항

Summary by CodeRabbit

  • New Features
    • Admin Orders: Notifications for new orders now auto-clear when orders are no longer waiting for payment, keeping the toast list accurate and uncluttered.
  • Chores
    • Improved monitoring in the user app by capturing console logs, warnings, and errors in Sentry for better visibility into issues.

@coderabbitai
Copy link

coderabbitai bot commented Sep 2, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Adds purgeNonWaiting to the new-order toast store to remove toasts for orders not in WAITING_FOR_PAYMENT. AdminOrders calls this on orders changes. User app’s Sentry init adds consoleLoggingIntegration to capture console logs. No other logic or signatures changed.

Changes

Cohort / File(s) Summary
New order toast store API
apps/nowait-admin/src/hooks/useNewOrderToastStore.tsx
Adds public method purgeNonWaiting(orders: Order[]) that keeps toasts only for orders with status WAITING_FOR_PAYMENT; removes others via existing removeToast. Imports Order. No changes to pushToast/removeToast signatures.
Admin orders integration
apps/nowait-admin/src/pages/AdminOrders/AdminOrders.tsx
Imports useNewOrderToastStore; selects purgeNonWaiting; useEffect calls purgeNonWaiting(orders) when orders changes (if non-empty). Rendering unchanged.
Sentry console logging
apps/nowait-user/src/utils/initSentry.ts
Adds Sentry.consoleLoggingIntegration({ levels: ["log","warn","error"] }) to integrations. Other config unchanged.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor Admin as Admin UI
  participant AdminOrders as AdminOrders.tsx
  participant ToastStore as useNewOrderToastStore
  participant Toasts as Toast List

  Admin->>AdminOrders: View orders page / refresh
  AdminOrders->>AdminOrders: orders fetched/updated
  AdminOrders->>ToastStore: purgeNonWaiting(orders)
  ToastStore->>ToastStore: Compute waiting IDs (status == WAITING_FOR_PAYMENT)
  alt toast.orderId not in waiting IDs
    ToastStore->>Toasts: removeToast(toastId)
  else
    ToastStore->>Toasts: keep
  end
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • Develop #420 — Also changes Sentry initialization in apps/nowait-user/src/utils/initSentry.ts, indicating overlapping configuration edits.

Suggested reviewers

  • dgKim1
  • hwangdae

Poem

A nibble of logs, a crunch of toast,
I prune the queues I love the most.
Waiting orders, stay in line—
Others hop away, just fine.
Console whispers, errors sing,
Sentry hears each little thing. 🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 507498c and b1e615d.

📒 Files selected for processing (3)
  • apps/nowait-admin/src/hooks/useNewOrderToastStore.tsx (3 hunks)
  • apps/nowait-admin/src/pages/AdminOrders/AdminOrders.tsx (3 hunks)
  • apps/nowait-user/src/utils/initSentry.ts (1 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch develop

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot requested a review from hwangdae September 2, 2025 07:57
@oriNuguri25 oriNuguri25 merged commit d4396aa into main Sep 2, 2025
2 of 3 checks passed
@coderabbitai coderabbitai bot mentioned this pull request Sep 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants