Skip to content

Conversation

@hwangdae
Copy link
Collaborator

@hwangdae hwangdae commented Sep 2, 2025

작업 내용

문제점 및 어려움

해결 방안

공유 사항

Summary by CodeRabbit

  • New Features
    • Success screens now support both image URLs and inline SVG illustrations.
    • Waiting Success page updated to a scalable SVG graphic for crisper visuals.
  • Style
    • Minor spacing adjustments to headings in the order confirmation modal for improved readability.

@coderabbitai
Copy link

coderabbitai bot commented Sep 2, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Updates API endpoints in order.ts to use root-relative paths and adjusts axios baseURL. Refactors SuccessMessagePage to accept either a string URL or an SVG React component via a renamed prop (ImageSrc), and updates its consumers. Minor styling tweaks applied to ConfirmModal headings.

Changes

Cohort / File(s) Summary
API endpoint/path updates
apps/nowait-user/src/api/order.ts
axios baseURL set to "/"; createOrder and getOrderDetails switched from API_URI-prefixed URLs to root-relative paths; getStorePayments unchanged.
SuccessMessagePage prop refactor
apps/nowait-user/src/components/common/SuccessMessagePage.tsx
Prop renamed imageSrc → ImageSrc; type widened to string or React SVG component; conditional render added for string URL vs. SVG component.
Consumers of SuccessMessagePage
apps/nowait-user/src/pages/order/orderSuccess/OrderSuccessPage.tsx, apps/nowait-user/src/pages/waiting/waitingSuccess/WaitingSuccessPage.tsx
Updated prop usage to ImageSrc; WaitingSuccess now imports SVG as React component (waitingSuccess.svg?react) instead of PNG path.
UI styling tweak
apps/nowait-user/src/components/order/ConfirmModal.tsx
Added px-1 padding to h1 and h2 classNames (presentation-only).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • merge to main #388 — Also changes createOrder/getOrderDetails URL construction but in the opposite direction (API_URI-prefixed), directly overlapping logic.
  • merge to main #343 — Introduces/uses API_URI in order.ts; this PR reverses some of that usage for specific calls.
  • merge to main #351 — Modifies the same order.ts functions to alter URL construction, directly intersecting with this change.

Suggested reviewers

  • dgKim1

Poem

whiskers twitch at the root of the path,
I hop from API_URI’s bath—
now “/” is home, neat and terse,
SVGs dance in React’s verse.
A pixel of padding, a celebrant cheer—
orders confirmed, success is here! 🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 2242656 and 9f3de06.

⛔ Files ignored due to path filters (5)
  • apps/nowait-user/src/assets/default-department.png is excluded by !**/*.png
  • apps/nowait-user/src/assets/default-image-lg.png is excluded by !**/*.png
  • apps/nowait-user/src/assets/default-menu-image-sm.png is excluded by !**/*.png
  • apps/nowait-user/src/assets/waitingSuccess.png is excluded by !**/*.png
  • apps/nowait-user/src/assets/waitingSuccess.svg is excluded by !**/*.svg
📒 Files selected for processing (5)
  • apps/nowait-user/src/api/order.ts (3 hunks)
  • apps/nowait-user/src/components/common/SuccessMessagePage.tsx (3 hunks)
  • apps/nowait-user/src/components/order/ConfirmModal.tsx (1 hunks)
  • apps/nowait-user/src/pages/order/orderSuccess/OrderSuccessPage.tsx (1 hunks)
  • apps/nowait-user/src/pages/waiting/waitingSuccess/WaitingSuccessPage.tsx (1 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch develop

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@hwangdae hwangdae merged commit b267f99 into main Sep 2, 2025
2 of 3 checks passed
@github-actions github-actions bot requested a review from dgKim1 September 2, 2025 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants