Develop #450
Merged
Develop #450
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: 메뉴 순서 편집시 발생하는 드래그 에러 수정
fix: 배포 에러 수정
fix: 가격 입력 정책 수정
fix: 이미지 수정 시 업로드 안되는 문제 수정
feat: 회원가입 시 전화번호 받는 1차 로직 완성
|
Caution Review failedThe pull request is closed. WalkthroughIntroduces onboarding flow and terms UI in nowait-user with new components, modals, and routes. Updates AdminBooth MenuSection to use a local drag lock, refactors edit/view row rendering, and adds optional image upload in menu edits. Adjusts price input display behavior in admin modal. Adds new Tailwind utility classes. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor User
participant MS as MenuSection
participant U as uploadMenuImage
participant API as Menu API
User->>MS: Edit menu (updated {..., image?})
alt image is File
MS->>U: uploadMenuImage(file)
U-->>MS: { imageUrl }
MS->>API: PATCH menu { name, desc, price, imageUrl, sortOrder }
API-->>MS: 200 OK
else no file or string URL
MS->>API: PATCH menu { name, desc, price, imageUrl? , sortOrder }
API-->>MS: 200 OK
end
MS-->>User: UI re-renders (edit/view modes, DnD locked vertically)
sequenceDiagram
autonumber
actor User
participant R as Router
participant OB as OnboardingPage
participant TM as TermsModal
participant VM as ViewModal
User->>R: Navigate /onboarding
R-->>User: Render OnboardingPage
User->>OB: Enter phone number
OB-->>User: Validate (11 digits, 010 prefix)
User->>OB: Click Next
OB->>TM: Open TermsModal
User->>TM: Toggle agreements / View details
TM->>VM: onOpenViewModal(termType)
VM-->>User: Show selected terms content
User->>TM: Confirm (required terms agreed)
TM->>OB: Navigate /onboarding/success
R-->>User: Render Success page
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. ⛔ Files ignored due to path filters (4)
📒 Files selected for processing (14)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 내용
문제점 및 어려움
해결 방안
공유 사항
Summary by CodeRabbit
New Features
Refactor
Style