Skip to content

Conversation

@oriNuguri25
Copy link
Collaborator

@oriNuguri25 oriNuguri25 commented Sep 3, 2025

작업 내용

  1. 호출 중 새로고침 시 타이머 초기화 되는 문제 해결
  2. 디테일 외부 조리 완료 버튼 클릭 시 디테일 화면이 열리는 문제 해결
  3. 무한 스크롤 부분 뱃지 깨짐 문제 해결
  4. 검색 시 주점 프로필 이미지 깨짐 해결

문제점 및 어려움

해결 방안

공유 사항

Summary by CodeRabbit

  • New Features

    • My Waiting cards now use per-store persistent countdown timers for more accurate, consistent timing across slides and sessions.
  • Bug Fixes

    • “Cook complete” button no longer triggers the parent card tap.
    • Search results reliably show store profile images.
    • Tapping a new-order toast opens Orders with the correct status filter, updates history without stacking, and auto-dismisses the toast.
    • Order detail modals now close the modal and detail view after successful actions.
    • Improved small-screen truncation for store names to prevent overflow.

@coderabbitai
Copy link

coderabbitai bot commented Sep 3, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Updates admin order interactions (toast navigation, modal success handling, click propagation) and user app features (centralized countdown timer store, MyWaitingCard integration). Adjusts search types to include structured profileImage and new fields, updates SearchModal image usage, and applies a minor layout tweak and comment cleanup.

Changes

Cohort / File(s) Change summary
Admin Orders flow
apps/nowait-admin/src/components/NewOrderToast.tsx, apps/nowait-admin/src/pages/AdminOrders/DetailCard.tsx, apps/nowait-admin/src/pages/AdminOrders/OrderCard.tsx
NewOrderToast adds status to query, uses navigate replace, and removes toast post-navigation. DetailCard centralizes modal success handling to close modal and detail, passing a unified onSuccess. OrderCard’s cook-complete click now stops propagation to prevent parent click.
User timer centralization
apps/nowait-user/src/stores/timerStore.ts, apps/nowait-user/src/pages/home/components/MyWaitingCard.tsx
Adds persisted Zustand timer store managing per-store countdowns with APIs (set/update/reset/get/isActive/clear). MyWaitingCard switches from local timers to store-driven timers with slide-based init and 1s update interval.
Search model and UI alignment
apps/nowait-user/src/types/search.ts, apps/nowait-user/src/components/common/modal/SearchModal.tsx
SearchStore now uses structured ProfileImage, adds openTime and waitingCount, removes location/description/bannerImages. SearchModal image src updated to use profileImage?.imageUrl.
Minor UI/layout
apps/nowait-user/src/pages/home/components/MainCard.tsx, apps/nowait-admin/src/pages/AdminBooth/components/MenuSection.tsx
MainCard adjusts name label container width class for small screens; formatting cleanup on a type. MenuSection removes a comment line only.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor Admin as Admin User
  participant Toast as NewOrderToast
  participant Router as Router
  participant Store as ToastStore

  Admin->>Toast: Tap toast
  Toast->>Router: navigate(/admin/orders/{storeId}?order=...&status=..., {replace:true})
  Toast->>Store: removeToast(id)
  note right of Router: History entry replaced
Loading
sequenceDiagram
  autonumber
  actor User
  participant Card as MyWaitingCard
  participant Timer as useTimerStore

  User->>Card: Slide to store in CALLING
  alt No active timer
    Card->>Timer: setTimer(storeId, 600)
  end
  loop Every 1s while CALLING
    Card->>Timer: updateTimer(storeId)
    Timer-->>Card: getTimeLeft(storeId)
    Card-->>User: Render countdown
  end
Loading

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

Possibly related PRs

  • Develop #435 — Touches AdminOrders OrderCard and DetailCard modal/click behaviors, overlapping with this PR’s handlers.
  • fix: 주점 publicCode로 연결 #405 — Modifies SearchStore and SearchModal, directly related to the profileImage type change and its usage.
  • Develop #428 — Adjusts NewOrderToast flow with status propagation and navigation behavior, matching changes here.

Suggested reviewers

  • hwangdae
  • dgKim1

Poem

A carrot-clock ticks, soft and neat,
Timers hop in tidy beat.
Toasts leap—then vanish with a wink,
Modals close before you think.
Images pose, in proper frame—
Little bun applauds the game. 🥕🐇


📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 73277b4 and f8501fa.

📒 Files selected for processing (9)
  • apps/nowait-admin/src/components/NewOrderToast.tsx (1 hunks)
  • apps/nowait-admin/src/pages/AdminBooth/components/MenuSection.tsx (0 hunks)
  • apps/nowait-admin/src/pages/AdminOrders/DetailCard.tsx (2 hunks)
  • apps/nowait-admin/src/pages/AdminOrders/OrderCard.tsx (1 hunks)
  • apps/nowait-user/src/components/common/modal/SearchModal.tsx (1 hunks)
  • apps/nowait-user/src/pages/home/components/MainCard.tsx (2 hunks)
  • apps/nowait-user/src/pages/home/components/MyWaitingCard.tsx (3 hunks)
  • apps/nowait-user/src/stores/timerStore.ts (1 hunks)
  • apps/nowait-user/src/types/search.ts (1 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch refactor/user/search

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@oriNuguri25 oriNuguri25 closed this Sep 3, 2025
@github-actions github-actions bot requested a review from hwangdae September 3, 2025 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants