Develop #454
Merged
Develop #454
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: 토스트 알림 클릭시 상세주문정보 오픈 & 토스트 알림제거
refactor: 각종 변경 사항 반영
|
Caution Review failedThe pull request is closed. WalkthroughUpdates span admin and user apps: admin toast navigation now sets status, uses two-arg navigate, and removes the toast on tap; admin orders consolidate modal success handling and stop event bubbling on a button. User app adds a persisted multi-timer store and integrates it into MyWaitingCard, adjusts Search types and image binding, and applies minor UI tweaks. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant U as User
participant T as NewOrderToast
participant R as Router
participant S as ToastStore
U->>T: Tap toast
T->>R: navigate({ pathname, search:?status=... }, { replace: true })
T->>S: removeToast(id)
sequenceDiagram
autonumber
participant U as User
participant D as AdminOrders.DetailCard
participant M as ModalComponent
participant H as onSuccess (prop)
U->>D: Open detail
D->>M: Render with onClose(handleCloseModal), onSuccess(handleModalSuccess)
U->>M: Confirm action
M-->>D: onSuccess()
D->>H: Invoke onSuccess?()
D->>M: Close modal
D->>U: Close detail (onClose)
sequenceDiagram
autonumber
participant V as MyWaitingCard
participant TS as useTimerStore
participant T as setInterval(1s)
V->>TS: isTimerActive(storeId)?
alt Not active and status=CALLING
V->>TS: setTimer(storeId, 600)
end
T->>V: tick (if status=CALLING)
V->>TS: updateTimer(storeId)
V->>TS: getTimeLeft(storeId)
TS-->>V: timeLeft
V->>V: render formatTime(timeLeft)
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. 📒 Files selected for processing (9)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 내용
문제점 및 어려움
해결 방안
공유 사항
Summary by CodeRabbit
New Features
Bug Fixes
Style