feat: 주문api 수정

[hwangdae]

작업 내용

문제점 및 어려움

해결 방안

공유 사항

Summary by CodeRabbit

• Refactor
  • Streamlined network requests for greater consistency and reliability across the app.
  • Reduced disruptive pop-up alerts during order creation and when loading order details, resulting in a smoother experience.
  • Delegated error handling to the app’s existing mechanisms (loading/empty states), minimizing interruptions without changing user flows.
  • No changes to visible features or navigation; order creation and details viewing behave the same, with fewer interruptions.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

Centralizes HTTP calls by introducing a shared Axios instance and refactors createOrder/getOrderDetails to use it. Simplifies error handling and logging in OrderDetailsPage by delegating to react-query. Removes a user-facing alert in RemittanceWaitPage after order creation. No public API signatures changed.

Changes

Cohort / File(s)	Summary of changes
Centralized API client usage apps/nowait-user/src/api/order.ts	Added shared Axios instance (baseURL "/"; withCredentials: true). Updated createOrder and getOrderDetails to call this instance. Removed per-call withCredentials. Other exports unchanged.
Order details query flow simplification apps/nowait-user/src/pages/order/orderDetails/OrderDetailsPage.tsx	Replaced async wrapper with direct getOrderDetails in queryFn. Removed try/catch, response logging, and alert on error. Added a console log of fetched orderDetails after useQuery.
Remittance alert removal apps/nowait-user/src/pages/order/remittenceWait/RemittanceWaitPage.tsx	Removed alert of JSON response after order creation log. Other logic (payload, API call, success path, error/finally) unchanged.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor U as User
  participant ODP as OrderDetailsPage
  participant RQ as react-query
  participant API as api (Axios instance)
  participant S as Server

  U->>ODP: Navigate to Order Details
  ODP->>RQ: useQuery(queryFn = getOrderDetails)
  RQ->>API: GET /orders/{storeId}/tables/{tableId}
  API->>S: HTTP GET (withCredentials)
  S-->>API: 200/4xx response
  API-->>RQ: data/error
  RQ-->>ODP: data/error (default handling)
  Note over ODP: Logs orderDetails if present

Loading

sequenceDiagram
  autonumber
  actor U as User
  participant RWP as RemittanceWaitPage
  participant API as api (Axios instance)
  participant S as Server
  participant Nav as Router

  U->>RWP: Submit order
  RWP->>API: POST /orders (payload, withCredentials)
  API->>S: HTTP POST
  S-->>API: 200/4xx response
  API-->>RWP: data/error
  alt success
    RWP->>RWP: Store depositorName, clear cart
    RWP->>Nav: Navigate to next page
  else error
    RWP->>RWP: Handle error (no alert)
  end

Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• fix: 주문내역 확인 코드 생성 #468 — Touches the same API and page files, adjusting getOrderDetails usage and alert/log behavior.
• merge to main #378 — Refactors apps/nowait-user/src/api/order.ts to use a centralized API client for createOrder/getOrderDetails.
• feat: 주문내역 테이블아이디 확인 #470 — Modifies OrderDetailsPage.tsx and RemittanceWaitPage.tsx with overlapping error/alert control-flow changes.

Suggested reviewers

• dgKim1
• oriNuguri25

Poem

A hop, a skip, a tidy call—
One api burrow serves them all.
Alerts no more, just calm replies,
Query carrots, cached and wise.
With whiskers twitching, logs in sight,
I bound through orders—clean and light. 🥕🐇

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 7079ba0 and 5e074b3.

📒 Files selected for processing (3)

• apps/nowait-user/src/api/order.ts (3 hunks)
• apps/nowait-user/src/pages/order/orderDetails/OrderDetailsPage.tsx (1 hunks)
• apps/nowait-user/src/pages/order/remittenceWait/RemittanceWaitPage.tsx (0 hunks)

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch develop

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

• Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

• Visit our Status Page to check the current availability of CodeRabbit.
• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.