-
Notifications
You must be signed in to change notification settings - Fork 3
feat: 프록시 설정 #483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 프록시 설정 #483
Conversation
|
Caution Review failedThe pull request is closed. WalkthroughThe PR updates two order API calls to use root-relative paths, adds Vercel rewrite rules for /orders and /v1 to nowait.co.kr, introduces a simple cookie-reading utility with a console.log in OrderDetailsPage, and makes minor UI layout adjustments (dynamic viewport height and padding). Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor U as User
participant W as Nowait User App (Browser)
participant V as Vercel Rewrites
participant N as nowait.co.kr (Backend)
rect rgb(240,248,255)
note over W: Order actions using root-relative paths
U->>W: Place order / View order details
W->>V: POST /orders/create/:publicCode/:tableId
V-->>N: Rewrite to https://nowait.co.kr/orders/create/...
N-->>V: Response (order created)
V-->>W: Response
W->>V: GET /orders/items/:publicCode/:tableId
V-->>N: Rewrite to https://nowait.co.kr/orders/items/...
N-->>V: Response (order items)
V-->>W: Response
end
rect rgb(245,245,245)
note over W: Other API that still uses API_URI
W->>N: GET ${API_URI}/v1/... (direct, no rewrite)
N-->>W: Response
end
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. 📒 Files selected for processing (5)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
작업 내용
문제점 및 어려움
해결 방안
공유 사항
Summary by CodeRabbit
New Features
Bug Fixes
Style
Chores