refactor: type 에러 수정

[oriNuguri25]

작업 내용

문제점 및 어려움

해결 방안

공유 사항

Summary by CodeRabbit

• Refactor
  • Standardized internal order status typing by referencing a single shared definition, reducing duplication and improving type consistency across the app. This consolidation helps maintain alignment between modules and eases future maintenance. No changes to behavior, performance, or UI. No impact to user workflows or settings; notifications and toasts continue to function as before.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

Consolidates type definitions by removing a local OrderStatus alias in useNewOrderToastStore.tsx and importing OrderStatus (along with Order) from ../types/order. No runtime logic or API changes.

Changes

Cohort / File(s)	Summary
Type definition consolidation apps/nowait-admin/src/hooks/useNewOrderToastStore.tsx	Replace local OrderStatus union type with imported OrderStatus from ../types/order; keep Toast type referencing OrderStatus; no logic changes.

Sequence Diagram(s)

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

• refactor: type 수정 #459 — Adjusts OrderStatus by removing CANCELLED, directly impacting the imported type used here.
• Develop #457 — Modifies the shared OrderStatus (adding CANCELLED) in the same source now imported by this file.
• Develop #428 — Earlier edits to useNewOrderToastStore.tsx around OrderStatus/Toast; directly related to this file’s type usage.

Suggested reviewers

• hwangdae

Poem

I thump my paws at types aligned,
One source of truth, so cleanly defined.
No crunchy bugs, just tidy lines—
A carrot-topped refactor that shines.
Hippity-hop, the toasts still chime! 🥕🐇

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

• Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
• Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 75df3f2 and 1cc968d.

📒 Files selected for processing (1)

• apps/nowait-admin/src/hooks/useNewOrderToastStore.tsx (1 hunks)

✨ Finishing touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch develop

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}