-
Notifications
You must be signed in to change notification settings - Fork 3
Merge develop → main: UI 메뉴 활성화 로직 개선 및 버그 수정 #545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Changes from 10 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
688f54d
fid: 이미지 크롭 모달 스타일링 변경
dgKim1 eec03af
fix: 배포 오류 수정
dgKim1 24117ad
fix: 배포 오류 수정
dgKim1 656df24
Revert "fix: 배포 오류 수정"
dgKim1 b4885d8
fix: yarn.lock파일 추가
dgKim1 171d3ad
fix: 배포오류 수정
dgKim1 02399a9
Merge branch 'main' of https://github.com/GTable/NoWait_FE into develop
dgKim1 75c748a
chore: 패키지 의존성 재정리
dgKim1 1fc774a
fix: 다른 메뉴로 이동 시 메뉴 닫히게 처리 & 주문 메뉴 클릭시 활성화 처리
dgKim1 3b59cbe
Merge pull request #544 from GTable/fix/admin/ui
dgKim1 3a9e47c
feat: api 주소 네임 변경
hwangdae 83fe875
Merge pull request #546 from GTable/feat/user/api
hwangdae File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Binary file renamed
BIN
+9.48 MB
...win-arm64-npm-0.25.12-2a5a9f9710-10c0.zip → ...win32-x64-npm-0.25.12-2425a2e173-10c0.zip
Binary file not shown.
Binary file removed
BIN
-337 KB
.yarn/cache/@parcel-watcher-darwin-arm64-npm-2.5.1-12be747bca-10c0.zip
Binary file not shown.
Binary file not shown.
Binary file removed
BIN
-1.82 MB
.yarn/cache/@rollup-rollup-darwin-arm64-npm-4.53.2-5fce7146cd-10c0.zip
Binary file not shown.
Binary file added
BIN
+2.02 MB
.yarn/cache/@rollup-rollup-win32-x64-gnu-npm-4.53.2-e204c95015-10c0.zip
Binary file not shown.
Binary file added
BIN
+2.48 MB
.yarn/cache/@rollup-rollup-win32-x64-msvc-npm-4.53.2-b69273fe45-10c0.zip
Binary file not shown.
Binary file not shown.
Binary file removed
BIN
-2.77 MB
.yarn/cache/@tailwindcss-oxide-darwin-arm64-npm-4.1.17-d42dccd811-10c0.zip
Binary file not shown.
Binary file added
BIN
+3.04 MB
.yarn/cache/@tailwindcss-oxide-win32-x64-msvc-npm-4.1.17-1eb35761b5-10c0.zip
Binary file not shown.
Binary file not shown.
Binary file removed
BIN
-7.65 MB
.yarn/cache/lightningcss-darwin-arm64-npm-1.30.2-57ebf00548-10c0.zip
Binary file not shown.
Binary file added
BIN
+8.61 MB
.yarn/cache/lightningcss-win32-x64-msvc-npm-1.30.2-868de13b8a-10c0.zip
Binary file not shown.
Binary file not shown.
Binary file renamed
BIN
+34.3 MB
...cli-darwin-npm-2.58.0-0d6c4eb647-10c0.zip → ...-windows-64-npm-2.6.0-08a058737d-10c0.zip
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion | 🟠 Major
Avoid mutating the destructured path variable.
Reassigning the
pathvariable that comes from destructuring is confusing and violates clean code principles. Instead, compute the actual path in a separate variable to maintain clarity.Apply this diff to use a separate variable:
{menuItems.map(({ label, icon, activeIcon, path }) => { - //주문의 경우 클릭시 경로에 storeId가 붙기 때문에 추가 검증 + // 주문의 경우 클릭시 경로에 storeId가 붙기 때문에 추가 검증 + const actualPath = label === "주문" ? `/admin/orders/${storeId}` : path; - if (label === "주문") { - path = `/admin/orders/${storeId}`; - } - const isActive = pathname === path; + const isActive = pathname === actualPath; return ( <li key={label} className={`flex items-center gap-3 px-3 py-2 rounded-md text-title-18-semibold ${ isActive ? "bg-[#f5f5f5] text-black" : "text-black-50" }`} - onClick={() => { - navigate(path); - onClose(); - }} + onClick={() => { + navigate(actualPath); + onClose(); + }} >📝 Committable suggestion
🤖 Prompt for AI Agents