Skip to content

Conversation

@hwangdae
Copy link
Collaborator

@hwangdae hwangdae commented Jan 4, 2026

작업 내용

polygon 변환 코드 생성

문제점 및 어려움

해결 방안

공유 사항

Summary by CodeRabbit

  • New Features

    • Added a geographic data control panel on the map management page, enabling users to export geographic data to clipboard.
    • Expanded geographic dataset with additional university location entries and map data.
  • Chores

    • Code cleanup and internal refactoring to improve maintainability.

✏️ Tip: You can customize this high-level summary in your review settings.

@hwangdae hwangdae merged commit 66b9ea0 into main Jan 4, 2026
2 of 3 checks passed
@github-actions github-actions bot requested a review from dgKim1 January 4, 2026 08:30
@coderabbitai
Copy link

coderabbitai bot commented Jan 4, 2026

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

This PR adds geographic data for Korean universities (Korea University and Yeungnam University) to the geojson dataset, refactors imports in MapManagePage, and introduces a new data management control panel with JSON-to-clipboard functionality. It also updates import paths and removes unused commented code.

Changes

Cohort / File(s) Summary
Geographic Data Additions
apps/nowait-user/public/geojson/export.json, apps/nowait-user/public/geojson/university.geojson
Added OpenStreetMap export for Korea University Seoul Campus with full OSM metadata, and appended two Polygon features for Yeungnam University to the existing GeoJSON FeatureCollection.
University Configuration
apps/nowait-user/src/pages/waiting/boothMap/constants/university.ts
Added new UNIVERSITY entry for 영남대학교 서울캠퍼스; note: duplicate id collision with existing entry (both use id 1).
MapManagePage Refactoring
apps/nowait-user/src/pages/waiting/BoothMapManage/MapManagePage.tsx
Reorganized imports to reference boothMap module paths; removed MapHeader component; added geoData state with bottom-anchored control panel containing textarea and clipboard copy button for JSON polygon transformation.
Code Cleanup & Path Updates
apps/nowait-user/src/pages/waiting/boothMap/components/mapControls/CompassButton.tsx, apps/nowait-user/src/routes/Router.tsx
Removed commented-out markerRef declaration in CompassButton; updated MapManagePage import path in Router.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Suggested reviewers

  • dgKim1
  • oriNuguri25

Poem

🐰 A rabbit hops through mapped terrain,
With universities both new and plain,
Seoul campuses marked on the screen,
And data panels, clipboard-keen—
GeoJSON dreams, coordinate schemes! 📍

✨ Finishing touches
  • 📝 Generate docstrings

📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fc2a56a and 1797120.

⛔ Files ignored due to path filters (1)
  • .yarn/releases/yarn-4.9.2.cjs is excluded by !**/.yarn/**
📒 Files selected for processing (6)
  • apps/nowait-user/public/geojson/export.json
  • apps/nowait-user/public/geojson/university.geojson
  • apps/nowait-user/src/pages/waiting/BoothMapManage/MapManagePage.tsx
  • apps/nowait-user/src/pages/waiting/boothMap/components/mapControls/CompassButton.tsx
  • apps/nowait-user/src/pages/waiting/boothMap/constants/university.ts
  • apps/nowait-user/src/routes/Router.tsx

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants