Skip to content

Conversation

@hwangdae
Copy link
Collaborator

@hwangdae hwangdae commented Jan 15, 2026

작업 내용

테이블 오더 부분 API 경로 수정

문제점 및 어려움

해결 방안

공유 사항

Summary by CodeRabbit

  • Refactor
    • Restructured internal API communication across core services including menu management, order processing, and reservation handling.
    • Implemented centralized API configuration to standardize endpoint management patterns and improve code consistency across the application.
    • Enhanced modularity of backend integration to provide a more scalable and maintainable foundation for future development.

✏️ Tip: You can customize this high-level summary in your review settings.

@hwangdae hwangdae merged commit 10658a0 into main Jan 15, 2026
2 of 3 checks passed
@github-actions github-actions bot requested a review from oriNuguri25 January 15, 2026 09:45
@coderabbitai
Copy link

coderabbitai bot commented Jan 15, 2026

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

This PR refactors API request handling in the nowait-user application by introducing centralized Axios instances with configured base URLs (using VITE_SERVER_URI/v1), then removing redundant /v1 path prefixes from individual endpoint calls across three API modules (menu, order, reservation).

Changes

Cohort / File(s) Summary
API refactoring to centralized Axios instances
apps/nowait-user/src/api/menu.ts, apps/nowait-user/src/api/order.ts, apps/nowait-user/src/api/reservation.ts
All three API modules are updated to initialize a centralized Axios instance with baseURL configuration from environment variable VITE_SERVER_URI. Endpoint paths are simplified by removing the /v1 prefix from individual calls (e.g., /stores/{publicCode}/menus instead of /v1/stores/{publicCode}/menus). In reservation.ts, getInfiniteAllStores response handling changed to return response.data.response instead of response.data. Minimal error logging added in menu.ts.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

  • refactor: API경로 수정 #559 — Makes overlapping code-level changes to the same nowait-user API modules (centralized UserApi axios instance and removing/moving /v1 prefix in endpoints).
  • feat: 주문api 수정 #478 — Modifies apps/nowait-user/src/api/order.ts to introduce centralized Axios instance and update API calls.
  • Develop #384 — Modifies the same three API modules and changes how endpoint paths are constructed with store identifiers and prefixes.

Suggested reviewers

  • oriNuguri25
  • dgKim1

Poem

🐰 Hops through API calls with glee,
Centralizing axios, baseURL so free,
V1 prefixes stripped away with care,
Cleaner endpoints everywhere!

✨ Finishing touches
  • 📝 Generate docstrings


📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ede3deb and 34f4aa2.

📒 Files selected for processing (3)
  • apps/nowait-user/src/api/menu.ts
  • apps/nowait-user/src/api/order.ts
  • apps/nowait-user/src/api/reservation.ts

✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants