Issue394#397
Open
StepanSaenko wants to merge 8 commits into
Open
Conversation
If the node is named with only digit symbols, it can be the reason of the error: terminate called after throwing an instance of 'std::out_of_range' what(): vector::_M_range_check: __n (which is 12157) >= this->size() (which is 3) Aborted (core dumped) A function added to phylotree.cc shows a possible explanation
Added an std::out_of_range exception
MarioStanke
requested changes
Jul 21, 2023
MarioStanke
left a comment
MarioStanke
left a comment
Contributor
There was a problem hiding this comment.
Looks good, except for some indentation and a possibly unnecessary include.
| int error_message = parser.parse(); | ||
| if(error_message == 1){ | ||
| throw ProjectError("the parsing of " + filename + " has been unsuccessful. Please check, whether the syntax of your input file is correct" ); | ||
| } |
| std::cout << "An out_of_range exception occurred: " << e.what() << std::endl; | ||
| throw ProjectError("the parsing of " + filename + " has been unsuccessful. Probably, at least one node named with only digits. Please check, whether the syntax of your input file is correct" ); | ||
| } | ||
| fb.close(); |
Contributor
There was a problem hiding this comment.
indentation inconsistent with previous line
Comment on lines
+20
to
+25
| #include <iostream> | ||
| #include <stdio.h> | ||
| #include <stack> | ||
| #include <string> | ||
| #include <regex> | ||
| #include <stdexcept> |
Contributor
There was a problem hiding this comment.
Please remove duplicates and unnecessary includes. Is regex used at all?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added catching an exception for the error "An out_of_range exception occurred: vector::_M_range_check: __n (which is 12157) >= this->size() (which is 3)" possibly caused by an error in .nwk file