[WIP] ops refactor #454
Draft
[WIP] ops refactor #454
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@adrn, this is a start towards the refactor we discussed. |
nstarman
force-pushed
the
ops/refactor
branch
2 times, most recently
from
72d50c7 to
e985e5f
Compare
adrn
reviewed
Oct 3, 2025
nstarman
commented
Oct 3, 2025
adrn
reviewed
Oct 3, 2025
| @AbstractOperator.__call__.dispatch # type: ignore[misc] | ||
| def call(self: AbstractOperator, x: Coordinate, /) -> Coordinate: | ||
| @dispatch | ||
| def operate(self: AbstractOperator, obj: Coordinate, /) -> Coordinate: |
There was a problem hiding this comment.
Nice! I think we discussed having the "root" operate implementation be:
def operate(cls, params, tau, obj):where tau is the "proper time" and it's implemented in class method form. But maybe it's possible to implement as a method / replacement of the current __call__ mechanism? Either way, I think the default should take (tau, obj) and there should be a dispatch when only obj is passed like:
def operate(cls, params, obj):
return operate(cls, params, None, obj)Thoughts?
nstarman
force-pushed
the
ops/refactor
branch
2 times, most recently
from
b357925 to
1cf96f6
Compare
Signed-off-by: nstarman <[email protected]>
Signed-off-by: nstarman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.