crucible-mir: Check schema version even when parsing succeeds
#1661
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactoring only, no change in behavior.
It is possible for a MIR JSON file to parse even if the schema version doesn't match what is expected, as noticed in GaloisInc/saw-script#2852 (comment). This ensures that the schema version is checked regardless of whether parsing succeeds or not.
RyanGlScott
requested review from
qsctr,
samcowger,
sauclovian-g and
spernsteiner
sauclovian-g
approved these changes
Dec 2, 2025
RyanGlScott
deleted the
rgs/crucible-mir-fix-schema-version-check-yet-again-ugh-i-hate-this-function
branch
RyanGlScott
added a commit
to GaloisInc/saw-script
that referenced
this pull request
Dec 4, 2025
This bumps the `mir-json` and `crucible` submodules to bring in the changes from: * GaloisInc/mir-json#202 (Print `rustc` version information before `mir-json` version) * GaloisInc/crucible#1661 (`crucible-mir`: Check schema version even when parsing succeeds)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible for a MIR JSON file to parse even if the schema version doesn't match what is expected, as noticed in GaloisInc/saw-script#2852 (comment). This ensures that the schema version is checked regardless of whether parsing succeeds or not.