crucible-mir: Add basic align_of_val override
#1709
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RyanGlScott
commented
Jan 20, 2026
Comment on lines
+60
to
+62
| * Add an intrinsic for [`align_of_val`](https://doc.rust-lang.org/std/intrinsics/fn.align_of_val.html), | ||
| which computes the alignment of a value in bytes. This works for all sized types | ||
| as well as a limited number of unsized types (currently, only slices). |
Contributor
Author
There was a problem hiding this comment.
This changelog entry may need to be moved depending on the timing of the upcoming Crux release.
qsctr
approved these changes
Jan 20, 2026
Collaborator
qsctr
left a comment
qsctr
left a comment
There was a problem hiding this comment.
Technically the XFAIL message for the rc/rc_basic crux-mir test is now out of date, but the XFAIL will likely be removed very soon anyways when we incorporate the changes from GaloisInc/mir-json#221, so it's probably fine.
Contributor
Author
|
Yes, good point. I think I will park this PR until GaloisInc/mir-json#221 lands first and then incorporate that as a submodule bump, which will allow us to remove the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now, this override does not support trait objects or custom DSTs. This is still enough to be useful in practice despite these limitations. (See #1614 for the task of supporting trait objects/custom DSTs in this override.)
Fixes #1708.