crucible-mir: Support pointer arguments in atomic_xchg override
#1712
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RyanGlScott
commented
Jan 21, 2026
Comment on lines
+60
to
+61
| * Extend the override for the `atomic_xchg` intrinsic to support storing | ||
| pointer values in addition to integer values. |
Contributor
Author
There was a problem hiding this comment.
This changelog entry may need to be moved depending on the timing of the upcoming Crux release.
samcowger
approved these changes
Jan 21, 2026
spernsteiner
approved these changes
Jan 21, 2026
Extending other atomic intrinsics to support pointer arguments is left as future work. Fixes #1710.
RyanGlScott
force-pushed
the
T1710-atomic_xchg_pointer_arguments
branch
from
88cdba3 to
bffc15e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extending other atomic intrinsics to support pointer arguments is left as future work.
Fixes one part of #1710.