crucible-mir: Handle #[repr(transparent)] pointer-to-pointer casts
#1717
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RyanGlScott
reviewed
Jan 23, 2026
Comment on lines
+946
to
+950
| -- repr(transparent) pointer-to-pointer cast | ||
| (M.Misc, M.TyRawPtr (M.TyAdt an1 _ _) m1, M.TyRawPtr _ _) | ||
| | Just adt1 <- findAdt' col an1 | ||
| , Just fieldTy1 <- reprTransparentFieldTy col adt1 | ||
| -> evalCast' M.Misc (M.TyRawPtr fieldTy1 m1) e ty2 |
Contributor
There was a problem hiding this comment.
I wonder if we should have a similar case in transmuteExp? At the moment, crucible-mir errors at simulation time if you rewrite the cast_from_ptr_repr_transparent test case to use transmute instead of a cast, and I imagine that it's for largely the same reasons that this case fixes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1716.
Also improves the comment for the general pointer-to-pointer cast case where the pointer is unchanged.