Added CMake options WITH_HDF5 and WITH_SQLite3#582
Open
Conversation
ChrisJChang
requested changes
Apr 30, 2026
| endif() | ||
| else() | ||
| message("${BoldCyan} X No HDF5 C libraries found. Excluding hdf5printer and hdf5reader from GAMBIT configuration.${ColourReset}") | ||
| message("${BoldCyan} X HDF5 is disabled. Excluding hdf5printer and hdf5reader from GAMBIT configuration. Use -DWITH_MPI=ON to enable HDF5. ${ColourReset}") |
Collaborator
There was a problem hiding this comment.
Should be Use -DWITH_HDF5=ON to enable HDF5. Simply copy paste error.
Collaborator
|
I've checked and it works, after changing the message, it can be merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #581 by adding two new options
WITH_HDF5andWITH_SQLite3to our CMake system. By default both options are set to True, which corresponds to the current behaviour (automatically looking for HDF5 and SQLite3 on the system). If the CMake option is set to False, the HDF5/SQLite3-based printers and readers are ditched from the build configuration.If a user e.g. builds with
WITH_HDF5=Falseand then tries to run GAMBIT with a YAML file configured to use a HDF5 printer, they get the following error message