fix: display error message with Logger #556
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
yeah, but id still display some error message in the ui... Maybe smthng like "rate limited: try again later" so that its not completly empty? |
sorbo87
approved these changes
Mar 31, 2025
stevenjoezhang
force-pushed
the
opencollective
branch
from
0b02c39 to
d3d3610
Compare
|
@GameTec-live Updated: a new error message will display to notify the user about network error |
GameTec-live
approved these changes
Apr 12, 2025
GameTec-live
requested changes
Apr 12, 2025
| return error; | ||
| Logger log = Logger(); | ||
| log.d(e.toString()); | ||
| return ["(Failed to load contributors list, please try again later)"]; |
There was a problem hiding this comment.
Use a localization for that please
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GraphQL API provided by Open Collective is protected by Cloudflare, and some IPs from certain ISPs might be blocked, leading to access failures. The current default behavior when access fails is to display an error message, but this is unnecessary for ordinary users.
I have moved the display of related errors to the console.
