Skip to content

Conversation

@runcows
Copy link
Contributor

@runcows runcows commented Dec 24, 2025

  • removed the CSV file in favor of just having the list in generate.py
  • adds basic guidebook
  • addresses the remaining review comments

@Bloo-dev
Copy link
Member

I don't think removing the .csv is a good idea. It is true that the csv does not add any functionality, nor is it technically required.
However, for a non-code-savvy person it is way easier to edit a .csv, especially since it is in a well known directory, than to have dig through .py files until they find where the supported animals are defined. It does not cost us anything to have the .csv but adds clarity.

@runcows
Copy link
Contributor Author

runcows commented Dec 24, 2025

I actually firmly disagree.

I think the CSV was actually more buried and less friendly since it was in the raw folder. If I were a less code savvy person, unfamiliar with our code base, I'd first check data, but see nothing, then see a file called generate and check there. Separating the CSV then adds a 3rd place to check, which you'd only find if you can read the python CSV reading or just check everywhere out of frustration.

@runcows
Copy link
Contributor Author

runcows commented Dec 26, 2025

I can change it back to the CSV if that's desired, but I do disagree. Not enough to die on this hill and stall this PR longer than needed though 😅

@EpyonProjects
Copy link
Member

EpyonProjects commented Dec 26, 2025

To be fair, we do have a lot of single lists within code and not separated. I don't know if we have a single column CSV anywhere and it does look weird to me, to be in a CSV rather than a format that accepts a simple list (of like 6 or 7 entries too, which is not much)

The raw folder is very confusing to me, I always pass it when browsing the codebase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants