Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mommy wants to be more ominous~ #84

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

mommy wants to be more ominous~ #84

wants to merge 1 commit into from

Conversation

lulu-eerie
Copy link

No description provided.

jyn514
jyn514 approved these changes Jul 26, 2024
View reviewed changes
Copy link

@jyn514 jyn514 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this gave me the fabulous idea to upper-case pronoun in all the ominous moods, i might make a pr for that later

responses.json
"{role} has seen worse. {pronoun} devoted {affectionate_term} can fix it. ...probably",
"{role} expected better from you. do not disappoint {pronoun} again",
"It seems {role}'s {affectionate_term} is becoming careless",
"{affectionate_term}, you are tarnishing the reputation of this house"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks like the first response that begins with affectionate_term. my understanding is that it's usually lowercase ("girl") by default. should we uppercase the first letter for consistency?

we may also want to consider ending all these phrases with a period if they don't have other punctuation, but that's a larger change, you don't have to do it here.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in #83 we actually moved to everything being lower haha

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh cool 10/10 no notes then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gankra Gankra Gankra left review comments

@jyn514 jyn514 jyn514 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lulu-eerie @Gankra @jyn514