Skip to content

Change return type from list[str] to list[dict] #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ZhengWentong wants to merge 3 commits into
base: main
Choose a base branch
from
+6 −1
Open

Change return type from list[str] to list[dict] #238

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e531071
Change return type from list[str] to list[dict]
ZhengWentong Jun 4, 2026
b40da0e
Add TypedDict for GenerateOutput in llm_engine.py
ZhengWentong Jun 4, 2026
e3b7a13
Merge pull request #1 from ZhengWentong/ZhengWentong-patch-2
ZhengWentong Jun 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion nanovllm/engine/llm_engine.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,18 @@
from tqdm.auto import tqdm
from transformers import AutoTokenizer
import torch.multiprocessing as mp
from typing import TypedDict

from nanovllm.config import Config
from nanovllm.sampling_params import SamplingParams
from nanovllm.engine.sequence import Sequence
from nanovllm.engine.scheduler import Scheduler
from nanovllm.engine.model_runner import ModelRunner

class GenerateOutput(TypedDict):
text: str
token_ids: list[int]


class LLMEngine:

Expand Down Expand Up @@ -62,7 +67,7 @@ def generate(
prompts: list[str] | list[list[int]],
sampling_params: SamplingParams | list[SamplingParams],
use_tqdm: bool = True,
) -> list[str]:
) -> list[GenerateOutput]:
pbar = tqdm(total=len(prompts), desc="Generating", dynamic_ncols=True, disable=not use_tqdm)
if not isinstance(sampling_params, list):
sampling_params = [sampling_params] * len(prompts)
Expand Down