-
Notifications
You must be signed in to change notification settings - Fork 229
Figure.logo: Add Pythonic parameters to specify the location and size #4014
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
seisman
wants to merge
14
commits into
main
Choose a base branch
from
refactor/logo
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
Improving an existing feature
needs review
This PR has higher priority and needs review.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GMT has 9 different embellishments, and they all share the same syntax for positioning. Refer to https://docs.generic-mapping-tools.org/6.5/reference/features.html#plot-embellishments for details.
The
logo
module's-D
option has the following syntax:in which
[g|j|J|n|x]refpoint[+jjustify][+odx[/dy]]
are common to all GMT embellishments.g|j|J|n|x
:mapcoords
/inside
/outside
/boxcoords
/plotcoords
. Long names are from upstream GMT codes, but see gmtlogo/psbasemap: Ensure the long options for -D are consistent with other modules gmt#8793+jjustify
: GMT usesjanchor
, but I feelanchor
is enough+o
: GMT usesanchoroffset
, but I feelanchor_offset
is more readablePreview: https://pygmt-dev--4014.org.readthedocs.build/en/4014/api/generated/pygmt.Figure.logo.html