Skip to content

Migrate the box parameter to the new alias system #4073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 56 commits into
base: main
Choose a base branch
from
Open

Migrate the box parameter to the new alias system #4073

wants to merge 56 commits into from
+76 −113

Conversation

seisman
Copy link
Member

@seisman seisman commented Sep 3, 2025 •
edited
Loading

seisman and others added 30 commits July 29, 2025 12:39
@seisman
Add the Box class for specifying box properties of embellishments
b73a6e2
@seisman @michaelgrund @yvonnefroehlich
Apply suggestions from code review
9f08d1b 
Co-authored-by: Michael Grund <[email protected]>
Co-authored-by: Yvonne Fröhlich <[email protected]>
@seisman
Use Box in examples and tests
01b563c
@seisman
Use Box in examples and tests
d2ae10c
@seisman
Fix API doc
ec1af1d
@seisman
Clarify that subclass must implement the _aliases property
48702b5
@seisman
Add validate method
210292f
@seisman
Fix the check logic
8e5321e
@seisman
Change to _validate
926a690
@seisman
Merge branch 'main' into AliasSystem/params/base
b1c6330
@seisman
Remove unneeded comments
bc31c7c
@seisman
Rename separator to sep
de1545f
@seisman
Merge branch 'main' into AliasSystem/params/base
44b0be3
@seisman
Merge branch 'main' into AliasSystem/params/base
1d14eb5
@seisman
Merge branch 'main' into AliasSystem/params/base
6ddcf4e
@seisman
Merge branch 'main' into AliasSystem/params/base
84ca37e
@seisman
Renanem the section header in doc api page
0313330
@seisman
Do not display False by default
40a47a8
@seisman
Fix repr
457abed
@seisman
Merge branch 'main' into AliasSystem/params/base
16c3d6c
@seisman @yvonnefroehlich
Apply suggestions from code review
ab7ad67 
Co-authored-by: Yvonne Fröhlich <[email protected]>
@seisman
Merge branch 'main' into AliasSystem/params/base
3c1ee05
@seisman
Merge branch 'main' into AliasSystem/params/base
9d60637
@seisman @yvonnefroehlich
Apply suggestions from code review
c4a19a5 
Co-authored-by: Yvonne Fröhlich <[email protected]>
@seisman
Check that inner_pen is set when inner_gap is set
5ec1180
@seisman
Fix the check of shading_offset and add a test
86d0a32
@seisman
Add more tests
4e98acf
@seisman
Remove print statements
22fb1eb
@seisman
Merge branch 'main' into AliasSystem/params/base
a83f21d
@seisman
Validate inner_pen/inner_gap in the _validate method
dce0e47
Base automatically changed from AliasSystem/params/base to main September 8, 2025 03:39
@seisman seisman added the needs review This PR has higher priority and needs review. label Sep 8, 2025
@seisman seisman marked this pull request as ready for review September 8, 2025 05:49
@seisman seisman requested a review from a team September 10, 2025 12:16
@seisman seisman added final review call This PR requires final review and approval from a second reviewer and removed needs review This PR has higher priority and needs review. labels Sep 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
final review call This PR requires final review and approval from a second reviewer maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Milestone
0.17.0
Development

Successfully merging this pull request may close these issues.
1 participant
@seisman