Various Bug fixes (Velocidex#3397)

* Source() plugin did not support versions when reading from notebook
cells.
* Add Cell from Hunt regression - hunt GUI was modified
* Adding new secret did not allow adding templates
* ACE default UI elements were not set when user's GUI record was
missing.

api/proto/api.proto

@@ -551,6 +551,13 @@ service API {
         };
     }
 
+    rpc DeleteSecretDefinition(SecretDefinition) returns (google.protobuf.Empty) {
+        option (google.api.http) = {
+            post: "/api/v1/DeleteSecretDefinition",
+            body: "*",
+        };
+    }
+
     rpc GetSecretDefinitions(google.protobuf.Empty) returns (SecretDefinitionList) {
         option (google.api.http) = {
             get: "/api/v1/GetSecretDefinitions",

api/secrets.go

@@ -74,6 +74,41 @@ func (self *ApiServer) DefineSecret(
 	return &emptypb.Empty{}, Status(self.verbose, err)
 }
 
+func (self *ApiServer) DeleteSecretDefinition(
+	ctx context.Context,
+	in *api_proto.SecretDefinition) (*emptypb.Empty, error) {
+
+	users := services.GetUserManager()
+	user_record, org_config_obj, err := users.GetUserFromContext(ctx)
+	if err != nil {
+		return nil, Status(self.verbose, err)
+	}
+	principal := user_record.Name
+
+	permissions := acls.SERVER_ADMIN
+	perm, err := services.CheckAccess(org_config_obj, principal, permissions)
+	if !perm || err != nil {
+		return nil, PermissionDenied(err,
+			"User is not allowed to manage secrets.")
+	}
+
+	secrets, err := services.GetSecretsService(org_config_obj)
+	if err != nil {
+		return nil, Status(self.verbose, err)
+	}
+
+	err = secrets.DeleteSecretDefinition(ctx, in)
+	if err == nil {
+		services.LogAudit(ctx,
+			org_config_obj, principal, "User Deleted Secret Type",
+			ordereddict.NewDict().
+				Set("principal", principal).
+				Set("type", in.TypeName))
+	}
+
+	return &emptypb.Empty{}, Status(self.verbose, err)
+}
+
 func (self *ApiServer) AddSecret(
 	ctx context.Context,
 	in *api_proto.Secret) (*emptypb.Empty, error) {