#2166: Fix - Time series information retrieved for read-only resources

[dsuren1]

Description

This PR fixes the following

• Time series information is now hidden for read-only resources
• Missing time series information for allowed resources is correctly retrieved and displayed in the details panel
• Fixed an issue where the pending indicator incorrectly appeared in the details panel when no data had been modified

Issue

• Time series information shouldn't be retrieved for read-only resouces #2166

[gemini-code-assist]

Summary of Changes

Hello @dsuren1, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on refining the display and management of time series data within the application. It addresses issues related to user permissions for viewing and editing time series information, ensuring that only authorized users can interact with these settings. Additionally, it corrects a UI anomaly where a 'pending' state was erroneously shown on detail pages, providing a more accurate representation of the resource's modification status.

Highlights

• Time Series Visibility: Time series information is now hidden for resources where the user lacks 'change_resourcebase' permissions, ensuring read-only resources do not display editable time series settings.
• Time Series Data Retrieval: The system now correctly retrieves and displays time series information for resources that have time-enabled data and where the user has appropriate permissions.
• Pending Indicator Accuracy: An issue where a pending indicator incorrectly appeared in the details panel when no data had been modified has been resolved, improving the accuracy of the UI state.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces several fixes related to time series information for resources. The changes correctly hide time series settings for read-only resources, ensure time series data is fetched when a resource has it, and resolve an issue with the pending changes indicator appearing incorrectly. The logic is sound and addresses the described issues. I've identified one potential issue in the code that could lead to an error if a resource is not found, and I've provided a suggestion to make the code more robust.

[allyoucanmap]

• the timeline is not visible in datasets after saving. I think we should not use timeseries endpoint to decide if we need to create dimensions or not. We should not use timeseries but instead has_time to decide if creating the dimensions object. Please ensure the timeline is working both for datasets and maps also after saving reloading the resource

[dsuren1]

• the timeline is not visible in datasets after saving. I think we should not use timeseries endpoint to decide if we need to create dimensions or not. We should not use timeseries but instead has_time to decide if creating the dimensions object. Please ensure the timeline is working both for datasets and maps also after saving reloading the resource

@allyoucanmap
I'm unable to replicate this case, where the timeline is not visible in dataset and map after saving. Kindly let me know if any specific steps needs to be followed

[dsuren1]

• the timeline is not visible in datasets after saving. I think we should not use timeseries endpoint to decide if we need to create dimensions or not. We should not use timeseries but instead has_time to decide if creating the dimensions object. Please ensure the timeline is working both for datasets and maps also after saving reloading the resource

The issue, caused by a race condition during parallel dataset and timeseries updates, has been resolved by implementing sequential call execution