-
Notifications
You must be signed in to change notification settings - Fork 26
feat: CI/CD pipeline to test-PR #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@TolisChal please review and merge |
@cbachela you also please take a look |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks you you please enable github actions in your fork to see whether your scripts passes without errors?
I think testing for formatting and types is not needed at this point.
Another question, do you manage to run tests locally in your machine? Are you using pytest?
Hey @vfisikop , thank you for reverting back. I was running pytest when I released the PR. I'll just get back with running this on my fork using github actions and removing unnecessary additions. Thanks |
@vfisikop i have managed to run this successfully in my forked github actions, but the tests are failing. I have not touched the test file just renamed it for usage purposes. I am updating the yml workflow and requirements file of this pr and you can as well check for the test failing issue. both locally and automated the tests are failing |
Signed-off-by: Arya Pratap Singh <[email protected]>
@vfisikop any updates on this? |
The tests should be fixed, for this PR to continue. Please open an issue. |
This PR adds a CI Pipeline to the existing code and Supports CodeCov coverage uploads.
Fixes Issue #5
Helps in improving code and PR quality