Skip to content

Create dingo-walk PyPi package #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

vfisikop
Copy link
Contributor

This is needed for creating a pip package (since the dingo name is already used).

@vfisikop vfisikop requested review from TolisChal and hariszaf March 11, 2025 20:55
@hariszaf
Copy link
Collaborator

Hi @vfisikop !
Having dingo on PyPi would be great 🎉 and dingo_walk is just fine.
However, I do not think that we need to change the namespace all over the project.
It's possible to have something like

pip install dingo_walk

and then

import dingo
..

If there is not a reason I am not aware of to change the namespace all over, I would suggest to go with the above solution.

@vfisikop
Copy link
Contributor Author

I proposed that change since I think it is more clear to have a unique name everywhere (namespace, package etc). Also since there is a package named dingo already (that has also the same name for its namespace) there is a conflict.

@hariszaf
Copy link
Collaborator

I have no strong opinion on this, I just really enjoyed the sklearn story when I first heard of it. 👨‍💻

@vfisikop
Copy link
Contributor Author

@TolisChal what is your opinion?

@vfisikop
Copy link
Contributor Author

vfisikop commented Apr 9, 2025

I agree to keep the dingo name everywhere instead of PyPi package where the name would be dingo-walk. It is clear and we do not have to use the dingo_walk (with "_") since in any case we cannot do import dingo-walk.

I updated my PR.

Copy link
Collaborator

@hariszaf hariszaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vfisikop for the PR!

Going through that it made me think we could deploy something this so we automatically fix formatting.

Not sure if that is the best example though; it's the first thing close to what I was thinking. 😃

simplejson = "^3.17.2"
Cython = "^0.29.22"
numpy = "^1.20.1"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

funny we had numpy twice.

# information about the dingo library
version = "0.1.0"
version = "0.1.5"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have never tried this before, but since the PyPi is the main goal of this PR, do you think we should consider setting something like this ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That could be an option, we should definitely discuss it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

However, the process of publishing with poetry is quite straightforward. For example, I am following this guide https://www.digitalocean.com/community/tutorials/how-to-publish-python-packages-to-pypi-using-poetry-on-ubuntu-22-04
So, I would not add more complication at this stage.

@vfisikop vfisikop changed the title Rename dingo to dingo_walk Create dingo-walk PyPi package Apr 10, 2025
@vfisikop
Copy link
Contributor Author

Thanks @vfisikop for the PR!

Going through that it made me think we could deploy something this so we automatically fix formatting.

Not sure if that is the best example though; it's the first thing close to what I was thinking. 😃

You mean for this PR or in general? We can discuss the auto-formatting. I have experience with that in Python but I have mixed filings in general. @TolisChal had used black for dingo at some point, AFAIKT.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants