Open
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Contributor
|
Currently the folium map designed to replace the two image plot is currently displaying in solid black and white over the basemap. The goal is to have a single colour for the value 1 and transparency for the value 0 for the classified data over the RGB image. Note that is considerably slower to load the folium map (8 seconds) compared to the images (1.5 seconds). This is probably irritating enough that I would consider sticking with the image method if it remains that slow but it would be neat to get the folium overlay working for the sake of it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Instead of having one classified map and one rgb map side-by-side, overlay them in folium.
The rgb is still not displaying correctly.
Checklist (replace
[ ]with[x]to check off)Load packagesGeneral advice)jupyterlab_code_formattertool can be used to format code cells to a consistent style: select each code cell, then clickEditand then one of theApply X Formatteroptions (YAPForBlackare recommended).NCIandDEA Sandbox(flag if not working as part of PR and ask for help to solve if needed)Notebook currently compatible with the NCI|DEA Sandbox environment onlyline below the notebook title to reflect the environments the notebook is compatible with