🐛 [BUG] Fix gpx and kml parsing: geom is an empty GeometryCollection #4467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4467 +/- ##
=======================================
Coverage 98.46% 98.46%
=======================================
Files 269 269
Lines 21471 21473 +2
=======================================
+ Hits 21142 21144 +2
Misses 329 329 ☔ View full report in Codecov by Sentry. |
Geotrek-admin
|
||||||||||||||||||||||||||||
| Project |
Geotrek-admin
|
| Branch Review |
refs/pull/4467/merge
|
| Run status |
|
| Run duration | 02m 12s |
| Commit |
|
| Committer | Justine Fricou |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
22
|
| View all changes introduced in this branch ↗︎ | |
Chatewgne
approved these changes
Jan 30, 2025
justinefricou
force-pushed
the
fix_parsing_gpx_geom_type
branch
from
14bf486 to
b40a095
Compare
…after invalid MultiLineString merge
justinefricou
force-pushed
the
fix_parsing_gpx_geom_type
branch
from
b40a095 to
48c04ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Merging a
MultiLineStringthat contains only two duplicate points returns an emptyGeometryCollection.This PR adds handling of this error case when parsing
.kmland.gpxfiles.Related Issue
Checklist
My code respects the Definition of done available in the Development section of the documentationI have commented my code, particularly in hard-to-understand areasI have made corresponding changes to the documentationThe title of my PR mentionned the issue associated