Skip to content

Conversation

@gwennlbh
Copy link
Member

@gwennlbh gwennlbh changed the base branch from main to module May 26, 2025 08:30
@gwennlbh gwennlbh force-pushed the odri branch 3 times, most recently from 9a40501 to 581db25 Compare May 26, 2025 12:26
gwennlbh added 3 commits May 26, 2025 15:32
Signed-off-by: Gwenn Le Bihan <[email protected]>
Signed-off-by: Gwenn Le Bihan <[email protected]>
Signed-off-by: Gwenn Le Bihan <[email protected]>
Copy link
Member

@nim65s nim65s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, you'll need to rebase as I fixed something in #58

@gwennlbh
Copy link
Member Author

Also, you'll need to rebase as I fixed something in #58

wait, do i target main instead of module ? the flake template mentions main not being ready yet

@nim65s
Copy link
Member

nim65s commented May 27, 2025

Hum, you’re right for module, I'll sync that

gwennlbh and others added 2 commits May 27, 2025 10:59
Signed-off-by: Gwenn Le Bihan <[email protected]>
@gwennlbh
Copy link
Member Author

gwennlbh commented May 27, 2025

i merged instead of rebasing but i think we'll squash before merging anyways

@gwennlbh
Copy link
Member Author

still no ci though :/ maybe sth to do with forks?

demos/ not available in postInstall

Signed-off-by: Gwenn Le Bihan <[email protected]>
@gwennlbh
Copy link
Member Author

nix flake check -L runs without errors locally, so it's a macos-only thing

@gwennlbh gwennlbh force-pushed the odri branch 4 times, most recently from 7529dbf to 5748786 Compare May 28, 2025 13:04
Signed-off-by: Gwenn Le Bihan <[email protected]>
Signed-off-by: Gwenn Le Bihan <[email protected]>
@gwennlbh gwennlbh requested a review from nim65s May 28, 2025 14:18
@nim65s nim65s merged commit 79143c3 into Gepetto:module Jun 3, 2025
4 checks passed
@nim65s
Copy link
Member

nim65s commented Jun 3, 2025

(forgot to squash before merging, so I force-pushed the previous state of that branch. I'm squashing this locally and will open another PR)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants