-
Notifications
You must be signed in to change notification settings - Fork 301
Improve accessibility of message list items #5911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve accessibility of message list items #5911
Conversation
SDK Size Comparison 📏
|
b80039d
to
3f6ee44
Compare
3f6ee44
to
9078438
Compare
b9e8269
to
f28c841
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good to me!
We should try to follow the approach of defining lambdas as nullable when they are optional(like the changes you did, such as onUserAvatarClick: (() -> Unit)? = null
), so that the talkback behaviour is better (for new features)
…tainer` is now nullable, allowing to have better semantics if click is unhandled.
…rnal `MessagesScreenContent` composable is now nullable, allowing to have better semantics if click is unhandled.
…read footer text handling
…he avatar semantics
…tion in message composer
f28c841
to
96b70a3
Compare
|
🎯 Goal
Improve accessibility of the message list items
🛠 Implementation details
onUserAvatarClick
parameter inMessagesScreen
andMessageContainer
is now nullable, as well as theonChannelAvatarClick
parameter and its internalMessagesScreenContent
composable, allowing to have better semantics if the click is unhandled.Out of scope changes
assertEquals
arguments inUserRobotMessageListAsserts
.🎨 UI Changes
Screen_recording_20250829_154007.webm
Screen_recording_20250829_153824.webm
🧪 Testing
Turn Talkback ON in System settings -> Accessibility options