Skip to content

Conversation

JcMinarro
Copy link
Contributor

@JcMinarro JcMinarro commented Sep 1, 2025

🎯 Goal

Filter out Poll Options differing only on whitespaces
Fix: AND-717

🎨 UI Changes

Before After
ui-componet-before.webm
ui-component-after.webm
Compose-before.webm
Compose-after.webm

Copy link
Contributor

github-actions bot commented Sep 1, 2025

SDK Size Comparison 📏

SDK Before After Difference Status
stream-chat-android-client 3.21 MB 3.21 MB 0.00 MB 🟢
stream-chat-android-offline 3.43 MB 3.43 MB 0.00 MB 🟢
stream-chat-android-ui-components 10.50 MB 10.50 MB 0.00 MB 🟢
stream-chat-android-compose 12.69 MB 12.69 MB 0.00 MB 🟢

@JcMinarro JcMinarro force-pushed the fix/poll-unique-option branch from ebf6225 to 17530e2 Compare September 2, 2025 18:20
@JcMinarro JcMinarro changed the title Filter options that only differ on some spaces Filter out Poll Options differing only on whitespaces Sep 2, 2025
@JcMinarro JcMinarro marked this pull request as ready for review September 2, 2025 18:39
@JcMinarro JcMinarro requested a review from a team as a code owner September 2, 2025 18:39
Copy link
Contributor

@VelikovPetar VelikovPetar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

One thing that I would like to point out though: I think that the current compose implementation is way too complex and quite difficult to debug/maintain - I think we should consider reworking the compose creation flow to follow the xml implementation - where the whole logic would be delegated to the CreatePollViewModel.

@JcMinarro
Copy link
Contributor Author

LGTM!

One thing that I would like to point out though: I think that the current compose implementation is way too complex and quite difficult to debug/maintain - I think we should consider reworking the compose creation flow to follow the xml implementation - where the whole logic would be delegated to the CreatePollViewModel.

I agree with you, creation logic shouldn't be duplicated by artifact, but keeping "the simplest one" on the common artifact, but it is out-of-scope of this PR.

@JcMinarro JcMinarro enabled auto-merge (squash) September 8, 2025 09:22
@VelikovPetar
Copy link
Contributor

Yes of course, I didn't mean to do it right now - just to point it out for future improvement!

Copy link

sonarqubecloud bot commented Sep 8, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@JcMinarro JcMinarro merged commit 6655d42 into develop Sep 8, 2025
12 of 13 checks passed
@JcMinarro JcMinarro deleted the fix/poll-unique-option branch September 8, 2025 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants