Skip to content

Ensure any callback action called from the CoilStreamImageLoader is run on the caller thread #5915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 8, 2025
Merged

Ensure any callback action called from the CoilStreamImageLoader is run on the caller thread #5915

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8145727
Ensure any callback action called from the CoilStreamImageLoader is r…
JcMinarro Sep 3, 2025
44a5a3e
Update CHANGELOG.md
JcMinarro Sep 3, 2025
7c0d4a2
Merge branch 'develop' into fix/coil
VelikovPetar Sep 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@

## stream-chat-android-ui-common
### 🐞 Fixed
- Ensure any callback action called from the CoilStreamImageLoader is run on the caller thread. [#5915](https://github.com/GetStream/stream-chat-android/pull/5915)

### ⬆️ Improved

Expand Down
37 changes: 21 additions & 16 deletions .../main/kotlin/io/getstream/chat/android/ui/common/images/internal/CoilStreamImageLoader.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,8 @@ import io.getstream.chat.android.ui.common.helper.DefaultImageHeadersProvider
import io.getstream.chat.android.ui.common.helper.ImageAssetTransformer
import io.getstream.chat.android.ui.common.helper.ImageHeadersProvider
import io.getstream.chat.android.ui.common.images.internal.StreamCoil.streamImageLoader
import kotlinx.coroutines.coroutineScope
import kotlinx.coroutines.launch
import kotlinx.coroutines.withContext

internal object CoilStreamImageLoader : StreamImageLoader {
Expand Down Expand Up @@ -146,10 +148,12 @@ internal object CoilStreamImageLoader : StreamImageLoader {
transformation: StreamImageLoader.ImageTransformation,
onStart: () -> Unit,
onComplete: () -> Unit,
) {
): Unit = coroutineScope {
val context = target.context

val drawable = withContext(DispatcherProvider.IO) {
val calledContext = coroutineContext

withContext(DispatcherProvider.IO) {
val asset = data.transformedAsset()
val headers = asset?.toString()?.let { url ->
imageHeadersProvider.getImageRequestHeaders(url).toNetworkHeaders()
Expand All @@ -162,27 +166,28 @@ internal object CoilStreamImageLoader : StreamImageLoader {
.error(placeholderDrawable)
.data(asset)
.listener(
onStart = { onStart() },
onCancel = { onComplete() },
onError = { _, _ -> onComplete() },
onSuccess = { _, _ -> onComplete() },
onStart = { launch(calledContext) { onStart() } },
onCancel = { launch(calledContext) { onComplete() } },
onError = { _, _ -> launch(calledContext) { onComplete() } },
onSuccess = { _, _ -> launch(calledContext) { onComplete() } },
)
.applyTransformation(transformation)
.build(),
)

result.image?.asDrawable(context.resources)
} ?: return

if (drawable is ScaleDrawable &&
Build.VERSION.SDK_INT >= Build.VERSION_CODES.P && drawable.child is AnimatedImageDrawable
) {
(drawable.child as AnimatedImageDrawable).start()
} else if (drawable is MovieDrawable) {
drawable.start()
}?.let { drawable ->
launch(calledContext) {
if (drawable is ScaleDrawable &&
Build.VERSION.SDK_INT >= Build.VERSION_CODES.P && drawable.child is AnimatedImageDrawable
) {
(drawable.child as AnimatedImageDrawable).start()
} else if (drawable is MovieDrawable) {
drawable.start()
}
target.setImageDrawable(drawable)
}
}

target.setImageDrawable(drawable)
}

override fun loadVideoThumbnail(
Expand Down
Loading