Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support campaign user pagination #1462

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

kanat
Copy link
Contributor

@kanat kanat commented Feb 1, 2025

Ticket

Backend PR

CLA

  • I have signed the Stream CLA (required).
  • Code changes are tested

Description of the changes, What, Why and How?

Changelog

@kanat kanat changed the title [CHA-536] support campaign user pagination (feat) support campaign user pagination Feb 1, 2025
Copy link
Contributor

github-actions bot commented Feb 1, 2025

Size Change: +79 B (+0.02%)

Total Size: 488 kB

Filename Size Change
dist/browser.es.js 106 kB +17 B (+0.02%)
dist/browser.full-bundle.min.js 59.8 kB +11 B (+0.02%)
dist/browser.js 108 kB +17 B (+0.02%)
dist/index.es.js 106 kB +17 B (+0.02%)
dist/index.js 108 kB +17 B (+0.02%)

compressed-size-action

@kanat kanat changed the title (feat) support campaign user pagination feat: support campaign user pagination Feb 3, 2025
src/client.ts Outdated Show resolved Hide resolved
@kanat kanat requested a review from myandrienko February 3, 2025 22:35
src/campaign.ts Outdated Show resolved Hide resolved
src/campaign.ts Outdated Show resolved Hide resolved
src/client.ts Outdated Show resolved Hide resolved
{
campaign: CampaignResponse;
users: {
next?: string;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are the returned cursors for when creating a campaign?

Copy link
Contributor Author

@kanat kanat Feb 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you pass more than 1,000 user_ids when creating a campaign, then in response you'll still get only 1,000 users with pager token

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And when do you get next and prev?

@MartinCupela
Copy link
Contributor

@kanat I could not find any topic-related docs at https://github.com/GetStream/docs-content/pulls/kanat. Do you plan to add some?

@kanat
Copy link
Contributor Author

kanat commented Feb 4, 2025

Hey @MartinCupela, thank you for the feedback 👍

Yup, I add the docs changes by Today.

@kanat kanat requested a review from MartinCupela February 4, 2025 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants