Fix unsetProperties not having any effect in CurrentUserController.updateUserData()
#3650
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SDK Performance
|
nuno-vieira
commented
Apr 16, 2025
| /// - completion: Called when user is successfuly updated, or with error. | ||
| func updateUserData( | ||
| name: String? = nil, | ||
| imageURL: URL? = nil, | ||
| privacySettings: UserPrivacySettings? = nil, | ||
| role: UserRole? = nil, | ||
| teamsRole: [String: String]? = nil, | ||
| teamsRole: [TeamId: UserRole]? = nil, |
There was a problem hiding this comment.
TeamId is not a breaking change. But UserRole it is kinda a breaking change. IMO it is not a big deal, but let me know WDYT. Overall it would be nice we keep the consistency of the types here.
There was a problem hiding this comment.
that's fine - we don't advertise this feature for now anyway.
SDK Size
|
|
martinmitrevski
approved these changes
Apr 17, 2025
| /// - completion: Called when user is successfuly updated, or with error. | ||
| func updateUserData( | ||
| name: String? = nil, | ||
| imageURL: URL? = nil, | ||
| privacySettings: UserPrivacySettings? = nil, | ||
| role: UserRole? = nil, | ||
| teamsRole: [String: String]? = nil, | ||
| teamsRole: [TeamId: UserRole]? = nil, |
There was a problem hiding this comment.
that's fine - we don't advertise this feature for now anyway.
nuno-vieira
deleted the
fix/unset-properties-not-used-in-current-user-controller
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Issue Links
https://linear.app/stream/issue/IOS-803/unsetproperties-does-not-do-anything-in-current-user-controller
🎯 Goal
Fix
unsetPropertiesnot having any effect inCurrentUserController.updateUserData().📝 Summary
unsetPropertiesnot doing anything inCurrentUserController.updateUserData().🧪 Manual Testing Notes
Result: User's image is reset in the channel list (image in the top left corner)
☑️ Contributor Checklist
docs-contentrepo