Demo-app-improvements #1333
Merged
Demo-app-improvements #1333
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SDK Size Comparison 📏
|
liviu-timar
force-pushed
the
demo-app-improvements
branch
from
5fe9170 to
da59a59
Compare
demo-app/src/main/kotlin/io/getstream/video/android/ui/call/CallScreen.kt
Show resolved
Hide resolved
stream-video-android-core/src/main/kotlin/io/getstream/video/android/core/StreamVideoClient.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (3)
stream-video-android-core/src/main/kotlin/io/getstream/video/android/core/StreamVideoClient.kt:1126
- Confirm that the StartClosedCaptionsRequest is properly initialized with all required parameters to ensure the closed captions feature behaves as expected.
coordinatorConnectionModule.api.startClosedCaptions(
demo-app/src/main/kotlin/io/getstream/video/android/ui/lobby/CallLobbyScreen.kt:261
- [nitpick] Consider renaming the lambda parameter from 'it' to a more descriptive name to improve clarity in the fallbackContent lambda.
val userName = it.user.userNameOrId
demo-app/src/main/kotlin/io/getstream/video/android/ui/call/CallScreen.kt:558
- [nitpick] Verify that the chosen padding values for the close button align with the overall design guidelines for consistency across the UI.
.padding(top = 10.dp, end = 10.dp),
|
aleksandar-apostolov
approved these changes
Apr 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Basic
demo-apppolishing.🛠 Implementation details
Share Calldialog (can be reopened fromParticipants) - I'll improve it by adding acollapsebutton.SharedPrefsfile to contain the version code to avoid caching.