[Enhancement]Improved audio session management #906
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ipavlidakis
added
bug
SDK Size
|
Public Interface+ extension RTCAudioSession
+
+ case isActive
+ case category
+ case mode
+ case useManualAudio
+ case isAudioEnabled
+ case device
+ case deviceIsExternal = "device.isExternal"
+ case deviceIsSpeaker = "device.isSpeaker"
+ case deviceIsReceiver = "device.isReceiver"
+
+
+ public func encode(to encoder: Encoder)throws
public enum ApplicationState: String, Sendable, Equatable
- case foreground, background
+ case unknown, foreground, background |
Generated by 🚫 Danger |
ipavlidakis
force-pushed
the
enhancement/improved-audio-session-management
branch
2 times, most recently
from
9dd1d4d to
0ae3530
Compare
ipavlidakis
force-pushed
the
enhancement/improved-audio-session-management
branch
from
0ae3530 to
d5c90bf
Compare
Sources/StreamVideo/Utils/AudioSession/StreamAudioSession.swift
Outdated
Show resolved
Hide resolved
Public Interface public enum ApplicationState: String, Sendable, Equatable
- case foreground, background
+ case unknown, foreground, background
- public struct AudioSessionConfiguration: ReflectiveStringConvertible, Equatable
+ public struct AudioSessionConfiguration: ReflectiveStringConvertible, Equatable, Sendable
public class Call: @unchecked Sendable, WSEventsSubscriber
- public func updateAudioSessionPolicy(_ policy: AudioSessionPolicy)async throws
+ public func updateAudioSessionPolicy(_ policy: AudioSessionPolicy)async |
Sources/StreamVideo/WebRTC/v2/StateMachine/Stages/WebRTCCoordinator+Joined.swift
Show resolved
Hide resolved
| @@ -124,15 +124,7 @@ actor WebRTCStateAdapter: ObservableObject, StreamAudioSessionAdapterDelegate { | |||
| self.rtcPeerConnectionCoordinatorFactory = rtcPeerConnectionCoordinatorFactory | |||
| self.videoCaptureSessionProvider = videoCaptureSessionProvider | |||
| self.screenShareSessionProvider = screenShareSessionProvider | |||
| self.audioSession = .init(audioDeviceModule: peerConnectionFactory.audioDeviceModule) | |||
There was a problem hiding this comment.
we should test audio filters and noise cancellation after these changes
There was a problem hiding this comment.
Audio filters shouldn't be affected as they are running directly in the WebRTC audio device module pipeline (which is the lower lever of the AudioSession we are using). In any case we should test them
.../StreamVideo/Utils/AudioSession/RTCAudioStore/Effects/RTCAudioStore+InterruptionEffect.swift
Show resolved
Hide resolved
ipavlidakis
force-pushed
the
enhancement/improved-audio-session-management
branch
from
b7a8c95 to
9b20956
Compare
ipavlidakis
force-pushed
the
enhancement/improved-audio-session-management
branch
from
8d31967 to
3a21a9d
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Issue Links
Resolves https://linear.app/stream/issue/IOS-1046/audio-issues
🎯 Goal
Provide a consistent and centralised way for managing AudioSession updates across SDK Components and Calls.
🛠 Implementation
This revision introduces
RTCAudioStorewhich is meant to be the control centre for AudioSession for the SDK, completely abstracting AVAudioSession and RTCAudioSession. The reason for this abstraction is that AVAudioSessionManagement and CallKit require things to happen in serial order. This order is whatRTCAudioStoreoffers.The architecture is Redux-based with 2 main Reducers (RTCAudioSessionReducer and CallKitAudioSessionReducer). Each of them is responsible with interacting with one external component (in this case RTCAudioSession and CallKit).
☑️ Contributor Checklist