Add support for redirects on 410 responses #155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jevgenijsp @kaspars-ozols @marisks |
ErvinsA
requested changes
Jan 14, 2025
| } | ||
|
|
||
| if (context.Response.StatusCode != 404) | ||
| if (context.Response.StatusCode != 404 && (_configuration.Handle410 && context.Response.StatusCode != 410)) |
There was a problem hiding this comment.
I think this check should be written in different way. One option would be to have list with status codes that context.Response.StatusCode could be checked against. Message should contain those status codes that application is configured to handle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Optimizely, expired pages respond with a 410 http response which is ignored by the NotFound Handler.
This PR adds a option to enable the redirect manager to work on 410 responses.