Fixed tailing slash index check, added caching timeout and fixed scro…#121
Fixed tailing slash index check, added caching timeout and fixed scro…#121kaspars-ozols merged 5 commits intomasterfrom
Conversation
src/Geta.Optimizely.Sitemaps/Areas/GetaOptimizelySitemaps/Pages/Shared/_Layout.cshtml
Outdated
Show resolved
Hide resolved
|
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces several valuable fixes and improvements. It makes the sitemap cache duration configurable, which is a great enhancement for flexibility. It also resolves a potential crash when processing URLs with trailing slashes and fixes a UI scrolling issue. The changes are well-implemented. I've identified one potential issue where a negative value for the cache expiration could cause an unhandled exception and have suggested a fix.
src/Geta.Optimizely.Sitemaps/Controllers/GetaSitemapController.cs
Outdated
Show resolved
Hide resolved
# Conflicts: # src/Geta.Optimizely.Sitemaps/Geta.Optimizely.Sitemaps.Views/Views/Shared/_ShellLayout.cshtml
Ensure the cache expiration time for sitemap data is always non-negative by applying a Math.Max check. This prevents potential errors caused by invalid configuration values.
|
3 participants
…lling issue
fixes #104 #84 #78 #112